Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destructuring commandArgs #45

Merged
merged 1 commit into from Mar 30, 2021
Merged

fix: destructuring commandArgs #45

merged 1 commit into from Mar 30, 2021

Conversation

bytemain
Copy link
Contributor

because commandArgs is Array, so if commandArgs = ["-m", "-s"];

then the args = [ ["-m", "-s"] ], and the execute not handle it, so stackwalk will fail and exit

@nornagon nornagon merged commit 97a012f into electron:master Mar 30, 2021
@bytemain bytemain deleted the patch-1 branch March 31, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants