Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing publish files #35

Merged
merged 1 commit into from
Aug 26, 2019
Merged

fix: add missing publish files #35

merged 1 commit into from
Aug 26, 2019

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Aug 5, 2019

Seems some files are missing in the latest v0.16.0 npm tarball

Resolves #36

@popod
Copy link

popod commented Aug 23, 2019

@jkleinsc please someone to merge this ? Thanks

Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pd4d10!

@jkleinsc jkleinsc merged commit 210eb56 into electron:master Aug 26, 2019
@jkleinsc
Copy link
Contributor

@popod this has been merged but it turns out there were additional issues. I just published 0.19.0 which resolves all the install issues.

@popod
Copy link

popod commented Aug 26, 2019

@jkleinsc Thanks ! Tested just now with 0.19.0 and this works well :)

@pd4d10 pd4d10 deleted the patch-2 branch October 8, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on minidump 0.16.0 installation
3 participants