build: update for 4.2.x (#15)

* build: update for 4.2.x * Track down error
electron · May 9, 2019 · 21a3ed0 · 21a3ed0
1 parent 6e589d5
commit 21a3ed0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "electron-mksnapshot",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "Electron version of the mksnapshot binary",
   "repository": "https://github.com/electron/mksnapshot",
   "bin": {

diff --git a/test/mksnapshot-test.js b/test/mksnapshot-test.js
@@ -27,6 +27,9 @@ describe('mksnapshot binary', function () {
     mksnapshot.stderr.on('data', function (data) { output += data })
 
     mksnapshot.on('close', function (code) {
+      if (code !== 0) {
+        console.log('Error calling mksnapshot', output)
+      }
       assert.equal(typeof code, 'number', 'Exit code is a number')
       assert.equal(code, 0, 'Exit code is not zero')
       assert.equal(output.indexOf('Loading script for embedding'), 0, output, 'Output is correct')
@@ -35,7 +38,10 @@ describe('mksnapshot binary', function () {
       done()
     })
 
-    mksnapshot.on('error', done)
+    mksnapshot.on('error', function (code) {
+      console.log('error Output is', output)
+      done()
+    })
   })
 
   it('fails for invalid JavaScript files', function (done) {