Skip to content

Commit

Permalink
chore: update deps, require Node 12 (#784)
Browse files Browse the repository at this point in the history
* test(electron-locator): use fixtures instead of running npm
* build(deps): upgrade to node-gyp@^8.1.0
* chore: require Node 12 LTS
* build(deps-dev): upgrade @types/yargs to ^17.0.2
* build(deps-dev): upgrade ts-node 10 10.2.0
* chore: emit and lint against ES2019
* refactor: use optional catch bindings

Co-authored-by: Mark Lee <electronjs@lazymalevolence.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
  • Loading branch information
3 people committed Aug 9, 2021
1 parent 60d277e commit e166132
Show file tree
Hide file tree
Showing 19 changed files with 8,106 additions and 13,231 deletions.
42 changes: 23 additions & 19 deletions .circleci/config.yml
@@ -1,7 +1,7 @@
step-restore-cache: &step-restore-cache
restore_cache:
keys:
- v1-dependencies-{{ arch }}-{{ checksum "package-lock.json" }}
- v1-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}

steps-test: &steps-test
steps:
Expand All @@ -15,41 +15,45 @@ steps-test: &steps-test
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
nvm install 10
nvm alias default 10
nvm install 12
nvm alias default 12
echo 'export NVM_DIR=${HOME}/.nvm' >> $BASH_ENV
echo "[ -s '${NVM_DIR}/nvm.sh' ] && . '${NVM_DIR}/nvm.sh'" >> $BASH_ENV
;;
Windows*|CYGWIN*|MINGW*|MSYS*)
nvm install 10.22.0
nvm use 10.22.0
nvm install 12.22.4
nvm use 12.22.4
;;
esac
- run: npm install --engine-strict
- run: yarn install --frozen-lockfile
- save_cache:
paths:
- node_modules
key: v1-dependencies-{{ arch }}-{{ checksum "package-lock.json" }}
- run: npm run lint
- run: npm run coverage
- run: npm run codecov
key: v1-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}
- run: yarn run lint
- run:
name: Tests with code coverage
command: yarn run coverage
environment:
DEBUG: electron-rebuild
- run: yarn run codecov


version: 2.1
orbs:
win: circleci/windows@1.0.0
jobs:
test-linux-10:
docker:
- image: circleci/node:10
<<: *steps-test
test-linux-12:
docker:
- image: circleci/node:12
- image: circleci/node:12-buster
<<: *steps-test
test-linux-14:
docker:
- image: circleci/node:14
- image: circleci/node:14-buster
<<: *steps-test
test-linux-16:
docker:
- image: circleci/node:16-buster
<<: *steps-test
test-mac:
macos:
Expand All @@ -69,21 +73,21 @@ jobs:
steps:
- checkout
- *step-restore-cache
- run: npm install
- run: yarn install --frozen-lockfile
- run: npx semantic-release
workflows:
version: 2
test_and_release:
# Run the test jobs first, then the release only when all the test jobs are successful
jobs:
- test-linux-10
- test-linux-16
- test-linux-12
- test-linux-14
- test-mac
- test-windows
- release:
requires:
- test-linux-10
- test-linux-16
- test-linux-12
- test-linux-14
- test-mac
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -44,7 +44,7 @@ npm run rebuild

### What are the requirements?

Node v10.12.0 or higher is required. Building the native modules from source uses
Node v12.13.0 or higher is required. Building native modules from source uses
[`node-gyp`](https://github.com/nodejs/node-gyp#installation), refer to the link for its
installation/runtime requirements.

Expand Down

0 comments on commit e166132

Please sign in to comment.