Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme" #1207

Merged
merged 2 commits into from Jun 9, 2020
Merged

Revert "Updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme" #1207

merged 2 commits into from Jun 9, 2020

Conversation

anikethsaha
Copy link
Member

Reverts #1182

@anikethsaha
Revert "update: updated docs site dark and light mode with switch and…
399cd16 
… redesigned search bar using docsify-darklight-theme (#1182)"

This reverts commit 415f295.
@vercel
Copy link

vercel bot commented Jun 9, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/8cun04yjz
✅ Preview: https://docsify-preview-git-revert-1182-develop.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 399cd16:

Sandbox Source
priceless-shape-dximf Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c4678b:

Sandbox Source
fast-field-cp0pi Configuration

sy-records
sy-records approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why revert？What's the problem?

@anikethsaha
Copy link
Member Author

@jhildenbiddle mentioned some valid points here #1182 (comment)

@anikethsaha anikethsaha merged commit 26cb940 into develop Jun 9, 2020
trusktr added a commit that referenced this pull request Jun 13, 2020
@trusktr
Merge branch 'develop' into docsify-class
b15f450 
* develop:
  Update build/css.js
  use a port for the tests that doesn't collide with common local server ports
  Revert "Updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme" (#1207)
  ci: added codesandbox build preview for PR reviews (#1193)
  Update cover.md (#1134)
  chore: update auto format config
This was referenced Jun 14, 2020
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jun 26, 2020
Merged
@sy-records sy-records deleted the revert-1182-develop branch December 25, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koooooo-7 Koooooo-7 Koooooo-7 approved these changes

@sy-records sy-records sy-records approved these changes

@jhildenbiddle jhildenbiddle Awaiting requested review from jhildenbiddle

@trusktr trusktr Awaiting requested review from trusktr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anikethsaha @Koooooo-7 @sy-records