feat: node 17 support

discordjs · Nov 12, 2021 · fbd68ee · fbd68ee
1 parent 38199a3
commit fbd68ee
Show file tree

Hide file tree

Showing 3 changed files with 457 additions and 804 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -36,6 +36,12 @@
             ],
             "include_dirs": ["<!@(node -p \"require('node-addon-api').include\")"],
             "sources": ["src/node-opus.cc"],
+            # gyp inside node v16 uses -rpath=$ORIGIN/ instead of -rpath=$ORIGIN/lib.target/
+            # which fixes a longstanding descreptancy between platforms as documented at https://github.com/nodejs/node-gyp/issues/2233
+            # This allows tests to pass for older, still buggy and inconsistent versions of node-gyp (and will be duplicative for npm >= 7 which bundles node-gyp >= v0.6.0)
+            'ldflags': [
+                "-Wl,-rpath=\$$ORIGIN/"
+            ],
         },
     ],
 }