Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error handler): add default handler to econnreset #759

Merged
merged 1 commit into from Apr 19, 2022
Merged

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Apr 19, 2022

Description

Add default handler to http-proxy econnreset event.

This event is not documented in official documentation:
https://github.com/http-party/node-http-proxy#listening-for-proxy-events

It is typed in:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/e626d3221693ea35ae4298bc8192ac4abebd225f/types/http-proxy/index.d.ts#L109

Event is emitted:
https://github.com/http-party/node-http-proxy/blob/9b96cd725127a024dabebec6c7ea8c807272223d/lib/http-proxy/passes/web-incoming.js#L158

Motivation and Context

Lack of this handler potentially causes server to crash (unconfirmed, difficult to replicate)

How has this been tested?

hotfix 馃

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.584% when pulling 20988a2 on econnreset into 4baae76 on 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants