Skip to content

Commit

Permalink
Release prep changes (#201)
Browse files Browse the repository at this point in the history
  • Loading branch information
bjankord committed Oct 30, 2021
1 parent b31de86 commit 0678273
Show file tree
Hide file tree
Showing 53 changed files with 71 additions and 200 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
@@ -1,4 +1,4 @@
name: Tests
name: CI
on: [push, pull_request]
env:
CI: true
Expand Down
10 changes: 9 additions & 1 deletion CHANGELOG.md
Expand Up @@ -4,12 +4,20 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [8.0.1]
## [Unreleased]
### Changed
- Updated repo to be compatible with stylelint v14. Updated stylelint peerDependency range from `^13.0.0` to `^14.0.0` [PR](https://github.com/bjankord/stylelint-config-sass-guidelines/pull/197)
- Renamed tests files extension from `.js`to `.spec.js`
- Moved manually tested passing and failing SCSS examples into `__tests__/manual-test-cases`

### Added
- Added node 16 to automated test matrix

### Removed
- Dropped official support for Node 10 [PR](https://github.com/bjankord/stylelint-config-sass-guidelines/pull/197)
- Removed node 10 from automated test matrix [PR](https://github.com/bjankord/stylelint-config-sass-guidelines/pull/198)
- Removed babel as a dev dependency, resolves issue with security vuln in glob-parent CVE-2020-28469
- Removed `src/.stylelint.json`

## [8.0.0]
### Added
Expand Down
21 changes: 9 additions & 12 deletions README.md
@@ -1,18 +1,20 @@
# stylelint-config-sass-guidelines

[![NPM version](http://img.shields.io/npm/v/stylelint-config-sass-guidelines.svg)](https://www.npmjs.org/package/stylelint-config-sass-guidelines)

[![Build Status](https://travis-ci.org/bjankord/stylelint-config-sass-guidelines.svg?branch=master)](https://travis-ci.org/bjankord/stylelint-config-sass-guidelines)
[![Downloads per month](https://img.shields.io/npm/dm/stylelint-config-sass-guidelines.svg)](http://npmcharts.com/compare/stylelint-config-sass-guidelines)

[![Dependency Status](https://david-dm.org/bjankord/stylelint-config-sass-guidelines.svg)](https://david-dm.org/bjankord/stylelint-config-sass-guidelines)
[![devDependency Status](https://david-dm.org/bjankord/stylelint-config-sass-guidelines/dev-status.svg)](https://david-dm.org/bjankord/stylelint-config-sass-guidelines/?type=dev)
[![Build Status](https://github.com/bjankord/stylelint-config-sass-guidelines/workflows/CI/badge.svg)](https://github.com/bjankord/stylelint-config-sass-guidelines/actions?workflow=CI)
[![Known Vulnerabilities](https://snyk.io/test/github/bjankord/stylelint-config-sass-guidelines/badge.svg)](https://snyk.io//test/github/bjankord/stylelint-config-sass-guidelines)
[![contributions welcome](https://img.shields.io/badge/contributions-welcome-brightgreen.svg?style=flat)](https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/CONTRIBUTING.md)
[![Downloads per month](https://img.shields.io/npm/dm/stylelint-config-sass-guidelines.svg)](http://npmcharts.com/compare/stylelint-config-sass-guidelines)

A stylelint config inspired by [sass-guidelin.es](https://sass-guidelin.es/).
> A stylelint config inspired by [sass-guidelin.es](https://sass-guidelin.es/).
This linter has been designed / tested with SCSS syntax based on the SCSS guidelines documented in https://sass-guidelin.es/. It is intended for use with SCSS syntax, not Sass (tab style) syntax.

This config:
- bundles the [`stylelint-scss` plugin pack](https://github.com/stylelint-scss/stylelint-scss) and turns on its rules that check for possible errors
- bundles the [`stylelint-order` plugin pack](https://github.com/hudochenkov/stylelint-order) and turns on its rules that check for possible errors
- bundles the [`postcss-scss` custom syntax](https://github.com/postcss/postcss-scss) and configures it

# Translations

* [Deutsch](page/de.md)
Expand Down Expand Up @@ -56,11 +58,6 @@ For example, to change the `indentation` to tabs and turn off the `number-leadin

## Documentation

### Plugins

* [`stylelint-order`](https://github.com/hudochenkov/stylelint-order): A plugin pack of order related linting rules for stylelint.
* [`stylelint-scss`](https://github.com/kristerkari/stylelint-scss): A collection of SCSS specific linting rules for stylelint

### Configured lints

This is a list of the lints turned on in this configuration, and what they do.
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Expand Up @@ -15,5 +15,5 @@ Releasing the project requires these steps:


[npm-url]: https://www.npmjs.com/package/stylelint-config-sass-guidelines
[release-scripts-url]: https://github.com/bjankord/stylelint-config-sass-guidelines/blob/master/package.json#L48-L50
[release-scripts-url]: https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/package.json#L48-L50
[github-release-url]: https://github.com/bjankord/stylelint-config-sass-guidelines/releases
4 changes: 1 addition & 3 deletions __tests__/README.md
@@ -1,8 +1,6 @@
# How to add tests

* Update `./src/.stylelintrc.json` with your new rules
* Run npm run build to generate `./index.js`
* Create your test file named after the scss-lint your you are adding a stylelint rule for
* Create your test file named after the scss lint your you are adding a stylelint rule for. For example, `__tests___/unit/bang-format.spec.js`
* Copy the code from one of the other tests into your test new file
* Update the test so you have .scss code that will produce lint you want to test for
* Add a console.log statement within the checkResult function in the test file passing `result` to the log statement. e.g. `console.log(result)`
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions __tests__/manual-test-cases/stylelint.config.js
@@ -0,0 +1,2 @@
const rules = require('../../index');
module.exports = {...rules};
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
@@ -1,4 +1,4 @@
const config = require("../index");
const config = require("../../index");
const stylelint = require("stylelint");
const postcss = require("postcss");
const scssSyntax = require("postcss-scss");
Expand Down
21 changes: 6 additions & 15 deletions package.json
Expand Up @@ -8,7 +8,9 @@
"stylelint-scss",
"scss",
"sass",
"guidelines"
"guidelines",
"lint",
"linter"
],
"author": "Brett Jankord",
"license": "MIT",
Expand Down Expand Up @@ -36,26 +38,15 @@
"stylelint": "^14.0.0"
},
"devDependencies": {
"prepend-file": "^2.0.0",
"shelljs": "^0.8.1",
"stylelint": "^14.0.0",
"tape": "^5.3.1"
},
"scripts": {
"build": "node scripts/build.js",
"release:major": "npm test && npm run build && npm version major -m \"Released version %s\" && npm publish && git push --follow-tags",
"release:minor": "npm test && npm run build && npm version minor -m \"Released version %s\" && npm publish && git push --follow-tags",
"release:patch": "npm test && npm run build && npm version patch -m \"Released version %s\" && npm publish && git push --follow-tags",
"scss-lint-failing-case": "cd src; bundle exec scss-lint failing-test-cases.scss -c .scss-lint.yml; exit 0",
"scss-lint-passing-case": "cd src; bundle exec scss-lint passing-test-cases.scss -c .scss-lint.yml; exit 0",
"stylelint-failing-case": "cd src; stylelint failing-test-cases.scss; exit 0",
"stylelint-passing-case": "cd src; stylelint passing-test-cases.scss; exit 0",
"tape": "tape \"__tests__/**/*.js\"",
"test": "npm run build && npm run tape"
},
"babel": {
"presets": [
"@babel/preset-env"
]
"stylelint-failing-case": "cd __tests__/manual-test-cases; stylelint failing-test-cases.scss",
"stylelint-passing-case": "cd __tests__/manual-test-cases; stylelint passing-test-cases.scss",
"test": "tape \"__tests__/unit/*.spec.js\""
}
}
14 changes: 0 additions & 14 deletions scripts/build.js

This file was deleted.

0 comments on commit 0678273

Please sign in to comment.