fix: prevent hoisting of the undefined global variable in browser.js
#1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriangalliat
changed the title
global variable in browser.jsglobal variable in browser.js
Because of JS hoisting `var global` to the top of the file, `typeof global` in `getGlobal()` will always be `undefined`. By using a different variable name like `globalObject`, we are able to read the "real" `typeof global` and get access to the global object that way.
|
@valeriangalliat This global var is also need to change? or add Line 395 in e218f8d |
|
@LinusU @NotMoni @jimmywarting PTAL |
jimmywarting
approved these changes
Nov 8, 2022
|
🎉 This PR is included in version 2.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
in some aftermath i think we should instead have used the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Because of JS hoisting
var globalto the top of the file,typeof globalingetGlobal()will always beundefined.This can be a problem when bundling this code and running it in an environment that doesn't have
selfofwindowdefined but hasglobal.In practice I ran into this issue after browserifying node-fetch and running the bundle in
node --experimental-fetch(just to test).I can confirm after this fix I can browserify node-fetch and have it expose the global
fetchfunction when run intonode --experimental-fetch.Changes
By using a different variable name like
globalObject, we are able to read the "real"typeof globaland get access to the global object that way.