Skip to content

Commit

Permalink
Fix ws transports methods params
Browse files Browse the repository at this point in the history
  • Loading branch information
ZIMkaRU committed May 30, 2023
1 parent 08a085a commit b6a407b
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions lib/transports/ws2.js
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,8 @@ class WSv2 extends EventEmitter {
* @see WSv2#cancelOrder
* @see WSv2#updateOrder
*
* @param {object|Array} order - order object model or array
* @param {object|Array} params - parameters or order object model or array
* @param {object|Array} params.order - order object model or array
* @returns {Promise} p - resolves on submit notification
* @example
* const o = new Order({
Expand All @@ -1897,11 +1898,12 @@ class WSv2 extends EventEmitter {
*
* console.log('order confirmed! status: %s', o.status)
*/
async submitOrder (order) {
async submitOrder (params) {
if (!this._isAuthenticated) {
throw new Error('not authenticated')
}

const order = params?.order ?? params
const packet = Array.isArray(order)
? order
: order instanceof Order
Expand Down Expand Up @@ -1978,15 +1980,18 @@ class WSv2 extends EventEmitter {
*
* @see WSv2#submitOrder
*
* @param {object[]|Array[]|number[]} orders - array of order models, arrays
* @param {object|object[]|Array[]|number[]} params - parameters or array of order models, arrays
* @param {object[]|Array[]|number[]} params.ids - array of order models, arrays
* or IDs to be cancelled
* @returns {Promise} p
*/
async cancelOrders (orders) {
async cancelOrders (params) {
if (!this._isAuthenticated) {
throw new Error('not authenticated')
}

const orders = params?.ids ?? params

return Promise.all(orders.map(o => {
return this.cancelOrder(o)
}))
Expand Down

0 comments on commit b6a407b

Please sign in to comment.