[actions] use node/install instead of node/run

import-js · May 13, 2021 · dd2f087 · dd2f087
1 parent cf3b7e2
commit dd2f087
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/.github/workflows/node-4+.yml b/.github/workflows/node-4+.yml
@@ -66,18 +66,18 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
+      - uses: ljharb/actions/node/install@main
         continue-on-error: ${{ matrix.eslint == 4 && matrix.node-version == 4 }}
-        name: 'npm install && npm run tests-only'
+        name: 'nvm install ${{ matrix.node-version }} && npm install, with eslint ${{ matrix.eslint }}'
         env:
           ESLINT_VERSION: ${{ matrix.eslint }}
           TRAVIS_NODE_VERSION: ${{ matrix.node-version }}
         with:
           node-version: ${{ matrix.node-version }}
           after_install: npm run copy-metafiles && ./tests/dep-time-travel.sh
-          command: 'tests-only'
-          after_success: 'npm run coveralls'
           skip-ls-check: true
+      - run: npm run tests-only
+      - run: npm run coveralls
 
   node:
     name: 'node 4+'

diff --git a/.github/workflows/node-pretest.yml b/.github/workflows/node-pretest.yml
@@ -8,20 +8,21 @@ jobs:
 
   #   steps:
   #     - uses: actions/checkout@v2
-  #     - uses: ljharb/actions/node/run@main
-  #       name: 'npm install && npm run pretest'
+  #     - uses: ljharb/actions/node/install@main
+  #       name: 'nvm install lts/* && npm install'
   #       with:
   #         node-version: 'lts/*'
-  #         command: 'pretest'
+  #         skip-ls-check: true
+  #     - run: npm run pretest
 
   posttest:
     runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run posttest'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
         with:
           node-version: 'lts/*'
-          command: 'posttest'
           skip-ls-check: true
+      - run: npm run posttest
diff --git a/.github/workflows/packages.yml b/.github/workflows/packages.yml
@@ -22,6 +22,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         package:
@@ -32,14 +33,16 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: ljharb/actions/node/run@main
-        name: 'npm install && npm run tests-only'
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
+        env:
+          ESLINT_VERSION: ${{ matrix.eslint }}
+          TRAVIS_NODE_VERSION: ${{ matrix.node-version }}
         with:
           node-version: ${{ matrix.node-version }}
-          after_install: npm run copy-metafiles && cd ${{ matrix.package }} && npm install
-          command: 'tests-only'
-          after_success: npm run coveralls
+          after_install: npm run copy-metafiles && ./tests/dep-time-travel.sh && cd ${{ matrix.package }} && npm install
           skip-ls-check: true
+      - run: cd ${{ matrix.package }} && npm run tests-only && npm run coveralls
 
   packages:
     name: 'packages: all tests'