Skip to content

Commit

Permalink
Upgrade node 12 (#19)
Browse files Browse the repository at this point in the history
* Upgrade to node v12

* upgrading package.json

* setting specific version

* switched to stretch
  • Loading branch information
bearjaws committed Feb 16, 2020
1 parent 0b4324b commit fa41bb9
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
test:
docker:
- image: circleci/node:8.12.0-jessie
- image: circleci/node:12.16.0-stretch
steps:
- checkout
- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
@@ -1,3 +1,3 @@
machine:
node:
version: 6.10.0
version: 12.13.0
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "wget-improved",
"version": "3.1.0",
"version": "3.2.0",
"description": "wget in nodejs, forked from wuchengwei/node-wget to add improvements and help maintain the project",
"keywords": [
"download",
Expand Down
7 changes: 4 additions & 3 deletions test/server.js
Expand Up @@ -4,9 +4,9 @@ const http = require('http');

const app = express();
let size = 1024 * 1024;
let file = new Buffer(size);
let file = Buffer.alloc(size);

let redirectFile = new Buffer(size);
let redirectFile = Buffer.alloc(size);
crypto.randomBytes(size, function(err, buffer) {
file = buffer;
});
Expand Down Expand Up @@ -75,7 +75,8 @@ module.exports = function() {
response.writeHead(200, {
'Content-Type': 'binary'
});
response.write(new Buffer(858478).toString('hex'));
let responseBuffer = Buffer.alloc(858478).toString('hex');
response.write(responseBuffer);
response.end();
})
.listen(9933);
Expand Down

0 comments on commit fa41bb9

Please sign in to comment.