Merge pull request #4802 from backstage/rugvip/onestore

core-api: skip wrapping the component data store in an object
backstage · Mar 4, 2021 · abf64c8 · abf64c8
2 parents 3a680d5 + c5a4d04
commit abf64c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/packages/core-api/src/extensions/componentData.test.tsx b/packages/core-api/src/extensions/componentData.test.tsx
@@ -100,19 +100,16 @@ describe('elementData', () => {
       const element = <Component />;
       const container = (global as any)[
         '__@backstage/component-data-store__'
-      ].store.get(element.type);
+      ].get(element.type);
       expect(container.map.get('my-data')).toBe(data);
     });
 
     it('should should be able to attach data for newer versions', () => {
       const data = { foo: 'bar' };
       const Component = () => null;
-      (global as any)['__@backstage/component-data-store__'].store.set(
-        Component,
-        {
-          map: new Map([['my-data', data]]),
-        },
-      );
+      (global as any)['__@backstage/component-data-store__'].set(Component, {
+        map: new Map([['my-data', data]]),
+      });
 
       const element = <Component />;
       expect(getComponentData(element, 'my-data')).toBe(data);

diff --git a/packages/core-api/src/extensions/componentData.tsx b/packages/core-api/src/extensions/componentData.tsx
@@ -33,9 +33,10 @@ type MaybeComponentNode = ReactNode & {
 };
 
 // The store is bridged across versions using the global object
-const { store } = getGlobalSingleton('component-data-store', () => ({
-  store: new WeakMap<ComponentType<any>, DataContainer>(),
-}));
+const store = getGlobalSingleton(
+  'component-data-store',
+  () => new WeakMap<ComponentType<any>, DataContainer>(),
+);
 
 export function attachComponentData<P>(
   component: ComponentType<P>,