Merge pull request #5185 from backstage/blam/fix-github-apps-auth

Fix GitHubApp URL parsing so we can get a token
backstage · Mar 31, 2021 · 39f4128 · 39f4128
2 parents d53d01d + 77893b6
commit 39f4128
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/warm-keys-yell.md b/.changeset/warm-keys-yell.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder-backend': patch
+---
+
+Fix a bug with GitHub Apps support not parsing the URL correctly
diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts
@@ -102,8 +102,12 @@ export function createPublishGithubAction(options: {
         );
       }
 
+      // TODO(blam): Consider changing this API to have owner, repo interface instead of URL as the it's
+      // needless to create URL and then parse again the other side.
       const { token } = await credentialsProvider.getCredentials({
-        url: `${host}/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}`,
+        url: `https://${host}/${encodeURIComponent(owner)}/${encodeURIComponent(
+          repo,
+        )}`,
       });
 
       if (!token) {