chore: make sure to throw when e2e fails

Signed-off-by: blam <ben@blam.sh>
backstage · Mar 4, 2021 · 2f98cf1 · 2f98cf1
1 parent f6171e4
commit 2f98cf1
Showing 1 changed file with 32 additions and 21 deletions.
diff --git a/packages/e2e-test/src/commands/run.ts b/packages/e2e-test/src/commands/run.ts
@@ -42,33 +42,44 @@ const templatePackagePaths = [
 ];
 
 export async function run() {
-  const rootDir = await fs.mkdtemp(resolvePath(os.tmpdir(), 'backstage-e2e-'));
-  print(`CLI E2E test root: ${rootDir}\n`);
-
-  print('Building dist workspace');
-  const workspaceDir = await buildDistWorkspace('workspace', rootDir);
-
-  const isPostgres = Boolean(process.env.POSTGRES_USER);
-  print('Creating a Backstage App');
-  const appDir = await createApp('test-app', isPostgres, workspaceDir, rootDir);
+  try {
+    const rootDir = await fs.mkdtemp(
+      resolvePath(os.tmpdir(), 'backstage-e2e-'),
+    );
+    print(`CLI E2E test root: ${rootDir}\n`);
+
+    print('Building dist workspace');
+    const workspaceDir = await buildDistWorkspace('workspace', rootDir);
+
+    const isPostgres = Boolean(process.env.POSTGRES_USER);
+    print('Creating a Backstage App');
+    const appDir = await createApp(
+      'test-app',
+      isPostgres,
+      workspaceDir,
+      rootDir,
+    );
 
-  print('Creating a Backstage Plugin');
-  const pluginName = await createPlugin('test-plugin', appDir);
+    print('Creating a Backstage Plugin');
+    const pluginName = await createPlugin('test-plugin', appDir);
 
-  print('Creating a Backstage Backend Plugin');
-  await createPlugin('test-plugin', appDir, ['--backend']);
+    print('Creating a Backstage Backend Plugin');
+    await createPlugin('test-plugin', appDir, ['--backend']);
 
-  print('Starting the app');
-  await testAppServe(pluginName, appDir);
+    print('Starting the app');
+    await testAppServe(pluginName, appDir);
 
-  print('Testing the backend startup');
-  await testBackendStart(appDir, isPostgres);
+    print('Testing the backend startup');
+    await testBackendStart(appDir, isPostgres);
 
-  print('All tests successful, removing test dir');
-  await fs.remove(rootDir);
+    print('All tests successful, removing test dir');
+    await fs.remove(rootDir);
 
-  // Just in case some child process was left hanging
-  process.exit(0);
+    // Just in case some child process was left hanging
+    process.exit(0);
+  } catch {
+    process.exit(1);
+  }
 }
 
 /**