Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[systemjs] Fix: export star alongside with named export #12612

Merged
merged 1 commit into from Jan 12, 2021
Merged

[systemjs] Fix: export star alongside with named export #12612

merged 1 commit into from Jan 12, 2021

Conversation

shrinktofit
Copy link
Contributor

@shrinktofit shrinktofit commented Jan 12, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #12573
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

By the way, I've just found 🙄 that GitKraken's diff tool is better than github's :
image

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37304/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85757c4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@shrinktofit
Copy link
Contributor Author

shrinktofit commented Jan 12, 2021 •
edited

Should I bump the version of @babel/plugin-transform-modules-systemjs?

@JLHwung
Copy link
Contributor

JLHwung commented Jan 12, 2021

By the way, I've just found 🙄 that GitKraken's diff tool is better than github's

You can click the gear button and disable whitespace changes.

Should I bump the version of @babel/plugin-transform-modules-systemjs?

Nope. It will be bumped automatically when we release.

@JLHwung JLHwung added area: modules PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 12, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title [systemjs] Fix: export star alongside with single export named [systemjs] Fix: export star alongside with named export Jan 12, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 2338b05 into babel:main Jan 12, 2021
This was referenced Mar 8, 2021
Closed
Merged
Closed
Closed
Open
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: modules outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reexports default could not co-exists with reexports star(SystemJS output)
4 participants
@shrinktofit @babel-bot @JLHwung @nicolo-ribaudo