Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining references to lerna #12592

Merged
merged 1 commit into from Jan 7, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 7, 2021

Q                       A
License MIT

Since we don't use lerna anymore, we should remove the lerna.json file to avoid creating confusion for new contributors.

We also don't need the lerna-changelog dependency, since that is handled by a GH action. If someone really needs to manually generate the changelog, they can still run yarn dlx lerna-changelog.

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 7, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36829/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c48d64:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang rip

@nicolo-ribaudo nicolo-ribaudo merged commit 866a742 into babel:main Jan 7, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the remove-lerna-refs branch January 7, 2021 09:22
@Sawtaytoes
Copy link

Is there a PR for when you transitions from Lerna to another technology?

I'm curious why this project isn't using Lerna anymore. I'm not partial either way, but I also saw the facebook/react repo is also no longer using Lerna either. What'd you replace it with?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jan 27, 2021

This is the PR removing lerna: #12138. The main reason is that we weren't using just lerna, but a fork.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants