fix(code-frame): do not pad gutter of empty lines

[SimenB]

Q	A
Fixed Issues?	Dunno 😅 It does most of jestjs/jest#10982
Patch: Bug Fix?	Yes
Major: Breaking Change?	Possibly, depending on whether the whitespace of the code frame is considered part of the contract (e.g. it'll break people snapshotting errors from Jest, but that is not a supported use case on Jest's side, so it doesn't matter)
Minor: New Feature?	No
Tests Added + Pass?	Yes
Documentation PR Link	N/A
Any Dependency Changes?	No
License	MIT

I don't think the trailing space adds anything.

[SimenB]

oops

[SimenB]

ergh, shouldn't matter, I thought for a moment the trailing spaces were inside the string. So I'll leave it as is for now unless you want me to roll back

[nicolo-ribaudo]

I'm surprised that it wasn't already fixed by prettier 🤔

[SimenB]

the ignore above it I assume 🙂

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36577/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d68324:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[nicolo-ribaudo]

Thanks!

[nicolo-ribaudo]

@SimenB I pushed a workaround since the Jest e2e test is failing (as expected).
We'll remove it once we publish a new version of @babel/code-frame and you update it in the Jest repo.

[SimenB]

@nicolo-ribaudo if you run against jest@master I can just apply a patch to the local install of @babel/code-frame until you release, if that's easier

[nicolo-ribaudo]

I don't want to force it on you since it's just caused by our tests, I just have to tune the regexp to make it pass 😅

[fisker]

I'm late for this, when we replace the EOL

Before

  1 | <LF>
  2 | <LF>
> 3 | class    a {<LF>
    |         ^^^^<LF>
> 4 |   b(  <|> ) {}<LF>
    | ^^^^^^^^^^^^^^<LF>
  5 | }<LF>
  6 | <LF>
  7 | let    x

After

  1 |<LF>
  2 |<LF>
> 3 | class    a {<LF>
    |         ^^^^<LF>
> 4 |   b(  <|> ) {}<LF>
    | ^^^^^^^^^^^^^^<LF>
  5 | }<LF>
  6 |<LF>
  7 | let    x

The first one looks more "real" 😄

Diff on Prettier PR, https://github.com/prettier/prettier/pull/10226/files#diff-802d6e48b5b7304cbc7abcb6aa1690a5419eecec01b4d971926a8ebd94548a04R85

Not important, but just want let you know.

[SimenB]

ah it's released, nice 👍

PR updating in Jest if you wanna remove the hack made to the e2e tests here: jestjs/jest#11048