Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add package-specific documentation links #12531

Merged
merged 15 commits into from Jan 6, 2021
Merged

docs: add package-specific documentation links #12531

merged 15 commits into from Jan 6, 2021

Conversation

danieleloscozzese
Copy link
Contributor

@danieleloscozzese danieleloscozzese commented Dec 21, 2020

Q                       A
Fixed Issues? n/a
Patch This only adds links to the documentation so it would be a patch version at most
Tests Added + Pass? n/a, only documentation links added
Any Dependency Changes? No
License MIT

This extends #10418 and adds package-specific homepage links to all of the packages which have one.
I ran a script checking the links, and removed any links which 404'd.
I also added "bugs" links to the packages which have a specific label mentioned in their README.

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 21, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36434/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 912ed08:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@merceyz
Copy link
Contributor

merceyz commented Dec 21, 2020

Seems like a job that should be covered by https://yarnpkg.com/features/constraints to avoid it falling out of sync

@danieleloscozzese danieleloscozzese marked this pull request as ready for review December 21, 2020 14:02
@nicolo-ribaudo nicolo-ribaudo added the PR: Docs 📝 A type of pull request used for our changelog categories label Dec 21, 2020
@nicolo-ribaudo
Copy link
Member

We didn't setup constraints yet, but it's in our list of things to do!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we'll wait to merge this until #12526 is merged, because this PR will probably cause every package to be published and I'd like to run #12526 for the first time with a small release.

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could use babel.dev, too. One byte shorter.

@danieleloscozzese
Copy link
Contributor Author

@JLHwung sure, I can switch the linked URLs out for the dot-dev domain.
I'll also fix up this conflict.

@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit e8b0852 into babel:main Jan 6, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants