Handle exprAllowed before ObjectLike is parsed #12267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 commits. The first commits fixes #11353 by correctly handling
exprAllowed
.Currently we use braceIsBlock to determine whether
{
starts an object literal or a blocked statement. However, this approach can not differentiate0 ? a : {}
toa : {}
because we do not track ternary in token context. Thus we incorrectly classify{}
as a statement block here.This PR fixes it on the parser level. It is not ideal but I think it is difficult to track it in tokenizing level performantly.
The second commit is to avoid accessing
this.prodParam
in token context update, because of the timing issues.