Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly wrap private class methods #12192

Merged
merged 1 commit into from Oct 16, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 16, 2020

Q                       A
Fixed Issues? Babel throws on transforming class C { async * #g() {} } (REPL)
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Any Dependency Changes?
License MIT

This PR fixes a bug caught by the test262 tests (Search "not ok 107")

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Generators Spec: Private Methods labels Oct 16, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30232/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b13fee5:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit a9cd094 into babel:main Oct 16, 2020
@JLHwung JLHwung deleted the fix-unwrapped-class-private-methods branch October 16, 2020 14:12
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Generators Spec: Private Methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants