chore: avoid duplicate coverage data upload #12187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I noticed that the coverage data of
@babel/traverse
is incorrect: https://codecov.io/gh/babel/babel/src/eec01fe078decb7d369cd2111c9f3881c4482788/packages/babel-traverse/src/path/index.jsi.e. The
NodePath
is a very popular. It is unlikely thatNodePath
had been executed only twice in the test suites. In fact I have checked out my local coverage report, theNodePath
has been executed for a million times:I checked out test process and realized that we uploaded coverage twice. I removed the one in
Makefile
and see the coverage oncodecov.io
is back to normal.I will mark as ready when this issue is resolved.