Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid duplicate coverage data upload #12187

Merged
merged 1 commit into from Oct 30, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 15, 2020

Q                       A
Fixed Issues? Avoid calling codecov API twice, reduce carbon footprint 😄
License MIT

Recently I noticed that the coverage data of @babel/traverse is incorrect: https://codecov.io/gh/babel/babel/src/eec01fe078decb7d369cd2111c9f3881c4482788/packages/babel-traverse/src/path/index.js

i.e. The NodePath is a very popular. It is unlikely that NodePath had been executed only twice in the test suites. In fact I have checked out my local coverage report, the NodePath has been executed for a million times:

image

I checked out test process and realized that we uploaded coverage twice. I removed the one in Makefile and see the coverage on codecov.io is back to normal.

I will mark as ready when this issue is resolved.

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 15, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30801/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83ee084:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung marked this pull request as ready for review October 15, 2020 19:29
@JLHwung
Copy link
Contributor Author

JLHwung commented Oct 15, 2020

Alright, it seems that the green number on codecov.io is how many builds (in our cases, only 1 build uploads coverage report) each line is covered in.

https://codecov.io/gh/babel/babel/src/744f239283337c1e3091a7905a0c057ed4877a94/packages/babel-traverse/src/path/index.js

image

When you hover on the green number 1, it will print the hit number (e.g. "> 10k"). Not particularly for my own purpose (finding the hottest path of @babel/traverse) but good to know about that.

That means #11968 should work, I will see if I can revive that PR.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 15, 2020
@existentialism existentialism merged commit 8ee4345 into babel:main Oct 30, 2020
@existentialism existentialism deleted the avoid-duplicate-coverage-upload branch October 30, 2020 14:28
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants