Support private properties for semi rule (#11748)

* Support private properties for semi rule * Combine selectors
babel · Jun 29, 2020 · 379e1c5 · 379e1c5
1 parent 5743ad3
commit 379e1c5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/eslint/babel-eslint-plugin/src/rules/semi.js b/eslint/babel-eslint-plugin/src/rules/semi.js
@@ -79,7 +79,7 @@ function report(context, node, missing) {
 export default ruleComposer.joinReports([
   rule,
   context => ({
-    ClassProperty(node) {
+    "ClassProperty, ClassPrivateProperty"(node) {
       const options = context.options[1];
       const exceptOneLine = options && options.omitLastInOneLineBlock === true;
       const sourceCode = context.getSourceCode();

diff --git a/eslint/babel-eslint-plugin/test/rules/semi.js b/eslint/babel-eslint-plugin/test/rules/semi.js
@@ -6,6 +6,7 @@ const ruleTester = new RuleTester();
 ruleTester.run("semi", rule, {
   valid: [
     "class Foo { bar = 'example'; }",
+    "class Foo { #bar = 'example'; }",
     "class Foo { static bar = 'example'; }",
     {
       code: "class Foo { bar = () => {}; }",
@@ -14,6 +15,7 @@ ruleTester.run("semi", rule, {
 
     // never
     { code: "class Foo { bar = 'example' }", options: ["never"] },
+    { code: "class Foo { #bar = 'example' }", options: ["never"] },
     { code: "class Foo { static bar = 'example' }", options: ["never"] },
     { code: "class Foo { bar = () => {} }", options: ["never"] },
   ],
@@ -22,6 +24,10 @@ ruleTester.run("semi", rule, {
       code: "class Foo { bar = 'example' }",
       errors: [{ message: "Missing semicolon." }],
     },
+    {
+      code: "class Foo { #bar = 'example' }",
+      errors: [{ message: "Missing semicolon." }],
+    },
     {
       code: "class Foo { static bar = 'example' }",
       errors: [{ message: "Missing semicolon." }],
@@ -38,6 +44,11 @@ ruleTester.run("semi", rule, {
       options: ["never"],
       errors: [{ message: "Extra semicolon." }],
     },
+    {
+      code: "class Foo { #bar = 'example'; }",
+      options: ["never"],
+      errors: [{ message: "Extra semicolon." }],
+    },
     {
       code: "class Foo { static bar = 'example'; }",
       options: ["never"],