Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating follow-redirects to version 1.14.7 #4379

Merged
merged 1 commit into from Jan 13, 2022

Conversation

guscsales
Copy link
Contributor

I notice the current version of axios@0.24.0 is using the follow-redirects@1.14.6 and recently was discovered a security vulnerability that was fixed on follow-redirects@1.14.7.

The overview of error is:

Affected versions of this package are vulnerable to Information Exposure by leaking the cookie header to a third party site in the process of fetching a remote URL with the cookie in the request body. If the response contains a location header, it will follow the redirect to another URL of a potentially malicious actor, to which the cookie would be exposed.

Here is the from follow-redirects commit with the fix that is currently on version 1.14.7: follow-redirects/follow-redirects@8b347cb.

@guscsales guscsales marked this pull request as ready for review January 12, 2022 15:04
@mrnonz
Copy link

mrnonz commented Jan 12, 2022

This line of code, I believe, will use the most recent patch version when installing.

"follow-redirects": "^1.14.4"

As a result, when you try to install Axios, it will resolve to follow-redirects@1.14.7 by default.

@guscsales
Copy link
Contributor Author

This line of code, I believe, will use the most recent patch version when installing.

"follow-redirects": "^1.14.4"

As a result, when you try to install Axios, it will resolve to follow-redirects@1.14.7 by default.

Hey, yes this works! Thanks for your comment. Is necessary to keep this PR just to update this library?

@Rados51
Copy link

Rados51 commented Jan 12, 2022

You can use resolutions in your package.json

"resolutions": {
"axios/follow-redirects": "^1.14.4"
}

Then you can upgrade it with yarn with yarn upgrade-interactive --latest

@jasonsaayman
Copy link
Member

Cool thanks, I know you can do the resolutions and that it should install the latest, but I will still accept this PR as cutting a new release on axios will cause things like dependabot to send out notices to update, release should be out tonight :)

@DanSmit
Copy link

DanSmit commented Jan 13, 2022

Thanks for fixing this. Any idea on when it will be released?

@Rados51
Copy link

Rados51 commented Jan 13, 2022

@jasonsaayman

This was more for other people that came across this and needed a fast solution due to security concerns from SNYK.
Thanks for your work!

@batalhao
Copy link

batalhao commented Jan 13, 2022

Hi @gussalesdev and team,

Thanks for fixing this.

@jasonsaayman
Copy link
Member

Thanks for fixing this. Any idea on when it will be released?

Will be in the next few hours

@citypaul
Copy link

Thanks for the quick fix everyone!

@fbritoferreira
Copy link

Thanks for fixing this. Any idea on when it will be released?

Will be in the next few hours

Seems like the release hasn't happened yet

@citypaul
Copy link

Any update on the release? We've had to point to the specific commit with the fix in it to unblock our pipeline at the moment.

@guillaumearnx
Copy link

guillaumearnx commented Jan 17, 2022

Any update ? Need to fix some modules on a big amount of servers .. 😅

@jasonsaayman
Copy link
Member

Released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants