Adding responseEncoding prop type in AxiosRequestConfig #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
approved these changes
Oct 4, 2021
|
Also see #3906 |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* Adding responseEncoding prop type in AxiosRequestConfig * Update index.d.ts Co-authored-by: Jay <jasonsaayman@gmail.com>
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request adds the responseEncoding property (present in the documentation) in the TypeScript AxiosRequestConfig interface, thus correcting the problems when building TypeScript. I put some of the most used encodings to make it easier for those who want to use this property and also leaving the possibility to choose any other type of encoding if necessary, accepting the encodings in string type.