Adding aborted event handler #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonsaayman Hi! Thank you for #3938. |
|
@jasonsaayman Hi! Thank you for new releases. https://github.com/axios/axios/releases/tag/v0.21.2 And this bug is blocker of using Node.js v14 in our products. Please let me know if you need to more information and have any help. Thank you for releasing while you are busy! |
|
Tagging this for next release |
|
@jasonsaayman Thank you sooo much! |
|
@jasonsaayman Thank you for maintaining this project! BTW, Any chance of a new release including this PR before #4209? |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* Adding test of aborts request * Adding aborted event handler * Fixing timing of setting rejected flag Co-authored-by: Jay <jasonsaayman@gmail.com>
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3798
Instructions
Adding aborted event handler.
abortedevent is emitted when a request is aborted with Node.js v14.Now, axios does not have a handler for
abortedevents, so axios cannot reject when that are aborted.This was not a problem in Node.js v12. But axios with Node.js v14 needs to be fixed.
Details: #3798