Avoid unnecessary Buffer allocations in Node.js #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puzpuzpuz please can you look at fixing the merge conflicts? |
…-unnecessary-buffer-allocations
|
@jasonsaayman done that. |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
httpadapter to avoid some unnecessaryBufferallocations.Bufferallocations are expensive as each buffer (note for Node.js 11.11.0 and newer: larger than 64 bytes) is baked with a chunk of off-heap memory (another note: there is also an internal "pool" to speed upBuffer.allocUnsafeandBuffer.concat, but its size is limited). Thus, they should be avoided where possible.