Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add independent maxBodyLength option #2781

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Add independent maxBodyLength option #2781

merged 4 commits into from
Mar 6, 2020

Conversation

gualopezb
Copy link
Contributor

This PR is intended to solve the confusion described on #2696 by adding a separate option in the request config to forward the maxBodyLength to the follow-redirects library.

chinesedfan
chinesedfan suggested changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, dist files can be ignored. We will update them together before releasing.

README.md Outdated Show resolved Hide resolved
test/unit/adapters/http.js Outdated Show resolved Hide resolved
chinesedfan
chinesedfan reviewed Feb 27, 2020
View reviewed changes
lib/adapters/http.js Outdated Show resolved Hide resolved
RubenVerborgh
RubenVerborgh approved these changes Feb 28, 2020
View reviewed changes
Copy link

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from the follow-redirects point of view.

@gualopezb
Copy link
Contributor Author

@chinesedfan I resolved the pending conflict on this PR. Feel free to merge it whenever you get a chance.

@chinesedfan chinesedfan changed the title Add independent option to set the maximum size of the request body Add independent maxBodyLength option Mar 6, 2020
@chinesedfan chinesedfan merged commit 6642ca9 into axios:master Mar 6, 2020
@chinesedfan chinesedfan mentioned this pull request Mar 7, 2020
Closed
@axios axios locked and limited conversation to collaborators May 3, 2020
@jasonsaayman jasonsaayman added this to the v0.20.0 milestone May 22, 2020
@jasonsaayman jasonsaayman added this to In progress in v0.20.0 via automation May 22, 2020
@jasonsaayman jasonsaayman moved this from In progress to Done in v0.20.0 May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RubenVerborgh RubenVerborgh RubenVerborgh approved these changes

@chinesedfan chinesedfan chinesedfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.20.0
  
Done
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gualopezb @RubenVerborgh @chinesedfan @jasonsaayman