New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing set config.method
after mergeConfig for Axios.prototype.request
#2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @bushuai, can you update your local branch? |
felipewmartins
approved these changes
Sep 6, 2019
Inside Axios.prototype.request function, It's forced to set method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective.
Thanks @bushuai |
genie-youn
pushed a commit
to genie-youn/axios
that referenced
this pull request
Sep 27, 2019
…est (axios#2383) Inside Axios.prototype.request function, It's forced to set method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective.
This was referenced Jan 7, 2020
This was referenced Apr 3, 2020
Closed
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside Axios.prototype.request function
It's forced to set
config.method
toGET
aftermergeConfig
ifconfig.method
existswhich makes the
defaults.method
not effective.HTTP method should be POST above.