New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unzipping response body only for statuses != 204 #1129
Conversation
2760755
to
48a7902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone please approve this merge request ❤️ I am facing this issue right now
Please merge this! this fixes #1658 |
Hey @antonmos I saw that I received an Email from you, unfortunately, I am not maintainer of this repository and I can`t do this. |
@emilyemorehouse thanks for merging this! When can we expect a release with this patch? This is causing a production bug for me. |
this update has an important change axios/axios#1129
Bugfix
When request has
Content-Encoding: gzip|deflate|compress
header and response has204 No Content
status code the following error is thrown:HttpClientError: unexpected end of file
.This pull request fixes the issue by calling
stream = stream.pipe(zip.createUnzip())
for all status codes but 204.