Skip to content

Commit

Permalink
Correctly add response interceptors to interceptor chain (#4013)
Browse files Browse the repository at this point in the history
  • Loading branch information
nerdbeere committed Sep 4, 2021
1 parent c0c8761 commit 83ae383
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/core/Axios.js
Expand Up @@ -81,7 +81,7 @@ Axios.prototype.request = function request(config) {
var chain = [dispatchRequest, undefined];

Array.prototype.unshift.apply(chain, requestInterceptorChain);
chain.concat(responseInterceptorChain);
chain = chain.concat(responseInterceptorChain);

promise = Promise.resolve(config);
while (chain.length) {
Expand Down
29 changes: 29 additions & 0 deletions test/specs/interceptors.spec.js
Expand Up @@ -252,6 +252,35 @@ describe('interceptors', function () {
});
});

it('should add a response interceptor when request interceptor is defined', function (done) {
var response;

axios.interceptors.request.use(function (data) {
return data;
});

axios.interceptors.response.use(function (data) {
data.data = data.data + ' - modified by interceptor';
return data;
});

axios('/foo').then(function (data) {
response = data;
});

getAjaxRequest().then(function (request) {
request.respondWith({
status: 200,
responseText: 'OK'
});

setTimeout(function () {
expect(response.data).toBe('OK - modified by interceptor');
done();
}, 100);
});
});

it('should add a response interceptor that returns a new data object', function (done) {
var response;

Expand Down

0 comments on commit 83ae383

Please sign in to comment.