Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixing an issue that type 'null' and 'undefined' is not assignable to…
… validateStatus when typescript strict option is enabled (#3200)
  • Loading branch information
cprayer committed Oct 20, 2020
1 parent 9a78465 commit 3a8b87d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion index.d.ts
Expand Up @@ -62,7 +62,7 @@ export interface AxiosRequestConfig {
onUploadProgress?: (progressEvent: any) => void;
onDownloadProgress?: (progressEvent: any) => void;
maxContentLength?: number;
validateStatus?: ((status: number) => boolean | null);
validateStatus?: ((status: number) => boolean) | null;
maxBodyLength?: number;
maxRedirects?: number;
socketPath?: string | null;
Expand Down
8 changes: 8 additions & 0 deletions test/typescript/axios.ts
Expand Up @@ -44,6 +44,14 @@ const config: AxiosRequestConfig = {
cancelToken: new axios.CancelToken((cancel: Canceler) => {})
};

const nullValidateStatusConfig: AxiosRequestConfig = {
validateStatus: null
};

const undefinedValidateStatusConfig: AxiosRequestConfig = {
validateStatus: undefined
};

const handleResponse = (response: AxiosResponse) => {
console.log(response.data);
console.log(response.status);
Expand Down

0 comments on commit 3a8b87d

Please sign in to comment.