handle non-object arguments #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schehata
force-pushed
the
islam/dx-363-check-if-you-can-pass-a-string-as-fields
branch
from
f009595
to
681c650
Compare
bahlo
deleted the
islam/dx-363-check-if-you-can-pass-a-string-as-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when arguments are spread like this
...argsit automatically converts to an objects, and then we lose the value.for example:
would result in
args = {0: 'b', 1: 'a', 2: 'r'}This PR, handles the arguments in the
_logmethod and checks if its an object or not, if the passed args is not an object, it will be stored infields.argsas it is.