Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge function compatibility #23

Merged
merged 8 commits into from
Jul 19, 2022

Conversation

schehata
Copy link
Collaborator

@schehata schehata commented Jul 18, 2022

Edge functions have middleware signature and should be treated same way as a middleware instead of being handled as a lambda api function.

bahlo added 2 commits July 8, 2022 09:38
Middleware is called from `worker.js` in Vercel and from
`evalmachine.<anonymous>` in local development.
@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-axiom-example ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 9:12AM (UTC)

@schehata schehata force-pushed the islam/dx-125-fixtest-edge-functions-with-axiom-next branch from 757af5c to ff4c2ae Compare July 18, 2022 12:44
@schehata schehata force-pushed the islam/dx-125-fixtest-edge-functions-with-axiom-next branch from 4e55f79 to 938cea1 Compare July 18, 2022 14:50
@schehata schehata marked this pull request as ready for review July 18, 2022 14:51
@schehata schehata requested a review from bahlo July 18, 2022 14:51
@schehata schehata force-pushed the islam/dx-125-fixtest-edge-functions-with-axiom-next branch 2 times, most recently from c0ee97e to 6e8c8e0 Compare July 18, 2022 14:54
@schehata schehata force-pushed the islam/dx-125-fixtest-edge-functions-with-axiom-next branch from 6e8c8e0 to a6d32a4 Compare July 18, 2022 15:10
@schehata schehata force-pushed the islam/dx-125-fixtest-edge-functions-with-axiom-next branch from a6d32a4 to 06380d6 Compare July 18, 2022 15:20
src/withAxiom.ts Outdated Show resolved Hide resolved
src/withAxiom.ts Show resolved Hide resolved
@schehata schehata requested a review from bahlo July 18, 2022 15:30
@bahlo bahlo changed the title Islam/dx 125 fixtest edge functions with axiom next Fix edge function compatibility Jul 19, 2022
src/withAxiom.ts Outdated Show resolved Hide resolved
src/withAxiom.ts Outdated Show resolved Hide resolved
src/withAxiom.ts Outdated Show resolved Hide resolved
Co-authored-by: Arne Bahlo <arne@axiom.co>
@schehata schehata merged commit c8acb35 into main Jul 19, 2022
@schehata schehata deleted the islam/dx-125-fixtest-edge-functions-with-axiom-next branch July 19, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants