fix (0.x): allow next 14 in peer deps #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
c-ehrlich
commented
Nov 13, 2023
•
c-ehrlich
commented
- allow next 14 in peer deps
- update example (only files with actual changes are index.tsx, package.json/package-lock, edge.ts)
- add prettier to example (formatting was inconsistent between files so there were no prettier rules that wouldn't have added a formatting diff)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c-ehrlich
changed the title
schehata
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
looks great, the only thing is the target branch pages-dir I am not sure if that's a new branch or an old one, the last one we used for 0.18 was branch next12, if you are not sure about pages-dir then we could merge into next12 or a new brach pages-router maybe that name better represents the package goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.