New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch and swallow exceptions on fetch #103
Conversation
while sending logs exceptions could happend, swallowing the exception ensures we don't interrupts customer apps or break api functions responses. We do the same in web-vitals.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM. Regarding the idea of removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm a bit concerned about deliverability if we don't await, otherwise nice work ✌️
would the function wait for the fetch to finish if we don't await ? that's basically our concern. |
removing await seems not to change anything, the logs still arrives safely, but I am not sure about the execution time yet, but it seems to be better than sending the logs with await. will merge this for now, and continue testing other scenarios. |
while sending logs exceptions could happend, swallowing the exception ensures we don't interrupts customer apps or break api functions responses. We do the same in web-vitals. I am not sure though about removing await, need to think about it and do some testing.