Remove callback route default

auth0 · Feb 1, 2021 · a52b686 · a52b686
1 parent 8f2e6ab
commit a52b686
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 6 deletions.
diff --git a/src/auth0-session/get-config.ts b/src/auth0-session/get-config.ts
@@ -133,7 +133,7 @@ const paramsSchema = Joi.object({
   issuerBaseURL: Joi.string().uri().required(),
   legacySameSiteCookie: Joi.boolean().optional().default(true),
   routes: Joi.object({
-    callback: Joi.string().uri({ relativeOnly: true }).default('/callback'),
+    callback: Joi.string().uri({ relativeOnly: true }).required(),
     postLogoutRedirect: Joi.string().uri({ allowRelative: true }).default('')
   })
     .default()

diff --git a/tests/auth0-session/client.test.ts b/tests/auth0-session/client.test.ts
@@ -11,7 +11,10 @@ const defaultConfig = {
   clientID: '__test_client_id__',
   clientSecret: '__test_client_secret__',
   issuerBaseURL: 'https://op.example.com',
-  baseURL: 'https://example.org'
+  baseURL: 'https://example.org',
+  routes: {
+    callback: '/callback'
+  }
 };
 
 const getClient = (params: ConfigParameters = {}): Promise<Client> =>

diff --git a/tests/auth0-session/config.test.ts b/tests/auth0-session/config.test.ts
@@ -4,7 +4,10 @@ const defaultConfig = {
   secret: '__test_session_secret__',
   clientID: '__test_client_id__',
   issuerBaseURL: 'https://op.example.com',
-  baseURL: 'https://example.org'
+  baseURL: 'https://example.org',
+  routes: {
+    callback: '/callback'
+  }
 };
 
 const validateAuthorizationParams = (authorizationParams: DeepPartial<AuthorizationParameters>): Config =>

diff --git a/tests/auth0-session/fixtures/helpers.ts b/tests/auth0-session/fixtures/helpers.ts
@@ -11,7 +11,10 @@ const clientId = '__test_client_id__';
 export const defaultConfig: Omit<ConfigParameters, 'baseURL'> = {
   secret,
   clientID: clientId,
-  issuerBaseURL: 'https://op.example.com'
+  issuerBaseURL: 'https://op.example.com',
+  routes: {
+    callback: '/callback'
+  }
 };
 
 export const toSignedCookieJar = (cookies: { [key: string]: string }, url: string): CookieJar => {

diff --git a/tests/auth0-session/handlers/logout.test.ts b/tests/auth0-session/handlers/logout.test.ts
@@ -115,7 +115,7 @@ describe('logout route', () => {
 
   it('should redirect to postLogoutRedirect', async () => {
     const postLogoutRedirect = 'https://example.com/post-logout';
-    const baseURL = await setup({ ...defaultConfig, routes: { postLogoutRedirect } });
+    const baseURL = await setup({ ...defaultConfig, routes: { ...defaultConfig.routes, postLogoutRedirect } });
     const cookieJar = await login(baseURL);
 
     const session: SessionResponse = await get(baseURL, '/session', { cookieJar });

diff --git a/tests/fixtures/default-settings.ts b/tests/fixtures/default-settings.ts
@@ -5,7 +5,10 @@ export const withoutApi: ConfigParameters = {
   clientID: '__test_client_id__',
   clientSecret: 'client_secret',
   baseURL: 'http://www.acme.com/',
-  secret: '__test_session_secret__'
+  secret: '__test_session_secret__',
+  routes: {
+    callback: '/api/auth/callback'
+  }
 };
 
 /**
@@ -20,5 +23,8 @@ export const withApi: ConfigParameters = {
   authorizationParams: {
     scope: 'openid profile read:customer',
     audience: 'https://api.acme.com'
+  },
+  routes: {
+    callback: '/api/auth/callback'
   }
 };