Skip to content

Commit

Permalink
fix(appium): type fixes for ts v5
Browse files Browse the repository at this point in the history
  • Loading branch information
boneskull committed Jul 3, 2023
1 parent 62f4244 commit c13333b
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions packages/appium/lib/extension/manifest.js
Expand Up @@ -284,7 +284,11 @@ export class Manifest {
...internal,
};
if (!_.isEqual(value, this.#data.drivers[pkgJson.appium.driverName])) {
this.setExtension(DRIVER_TYPE, pkgJson.appium.driverName, value);
this.setExtension(
/** @type {ExtType} */ (DRIVER_TYPE),
pkgJson.appium.driverName,
/** @type {ExtManifest<ExtType>} */ (value)
);
return true;
}
return false;
Expand All @@ -294,7 +298,11 @@ export class Manifest {
...internal,
};
if (!_.isEqual(value, this.#data.plugins[pkgJson.appium.pluginName])) {
this.setExtension(PLUGIN_TYPE, pkgJson.appium.pluginName, value);
this.setExtension(
/** @type {ExtType} */ (PLUGIN_TYPE),
pkgJson.appium.pluginName,
/** @type {ExtManifest<ExtType>} */ (value)
);
return true;
}
return false;
Expand Down

0 comments on commit c13333b

Please sign in to comment.