Add disableValidation option to apollo-server-core

apollographql · Nov 13, 2023 · 11f5981 · 11f5981
1 parent ea2e2c3
commit 11f5981
Show file tree

Hide file tree

Showing 7 changed files with 47 additions and 10 deletions.
diff --git a/docs/source/api/apollo-server.mdx b/docs/source/api/apollo-server.mdx
@@ -198,6 +198,20 @@ An array containing custom functions to use as additional [validation rules](htt
 </tr>
 
 
+<tr>
+<td>
+
+##### `disableValidation`
+
+`Boolean`
+</td>
+<td>
+
+Option to disable validation of graphql operations entirely.
+</td>
+</tr>
+
+
 <tr>
 <td>
 

diff --git a/packages/apollo-server-core/src/ApolloServer.ts b/packages/apollo-server-core/src/ApolloServer.ts
@@ -959,6 +959,7 @@ export class ApolloServerBase<
       logger: this.logger,
       plugins: this.plugins,
       documentStore,
+      disableValidation: this.config.disableValidation,
       context,
       parseOptions: this.parseOptions,
       ...this.requestOptions,

diff --git a/packages/apollo-server-core/src/graphqlOptions.ts b/packages/apollo-server-core/src/graphqlOptions.ts
@@ -62,6 +62,7 @@ export interface GraphQLServerOptions<
   persistedQueries?: PersistedQueryOptions;
   plugins?: ApolloServerPlugin[];
   documentStore?: DocumentStore | null;
+  disableValidation?: boolean;
   parseOptions?: ParseOptions;
   nodeEnv?: string;
   allowBatchedHttpRequests?: boolean;

diff --git a/packages/apollo-server-core/src/requestPipeline.ts b/packages/apollo-server-core/src/requestPipeline.ts
@@ -91,6 +91,7 @@ export interface GraphQLRequestPipelineConfig<TContext> {
   ) => GraphQLResponse | null;
 
   plugins?: ApolloServerPlugin[];
+  disableValidation?: boolean;
   documentStore?: DocumentStore | null;
 
   parseOptions?: ParseOptions;
@@ -257,18 +258,20 @@ export async function processGraphQLRequest<TContext extends BaseContext>(
       return await sendErrorResponse(syntaxError as GraphQLError, SyntaxError);
     }
 
-    const validationDidEnd = await dispatcher.invokeDidStartHook(
-      'validationDidStart',
-      requestContext as GraphQLRequestContextValidationDidStart<TContext>,
-    );
+    if (config.disableValidation !== true) {
+      const validationDidEnd = await dispatcher.invokeDidStartHook(
+        'validationDidStart',
+        requestContext as GraphQLRequestContextValidationDidStart<TContext>,
+      );
 
-    const validationErrors = validate(requestContext.document);
+      const validationErrors = validate(requestContext.document);
 
-    if (validationErrors.length === 0) {
-      await validationDidEnd();
-    } else {
-      await validationDidEnd(validationErrors);
-      return await sendErrorResponse(validationErrors, ValidationError);
+      if (validationErrors.length === 0) {
+        await validationDidEnd();
+      } else {
+        await validationDidEnd(validationErrors);
+        return await sendErrorResponse(validationErrors, ValidationError);
+      }
     }
 
     if (config.documentStore) {

diff --git a/packages/apollo-server-core/src/runHttpQuery.ts b/packages/apollo-server-core/src/runHttpQuery.ts
@@ -274,6 +274,7 @@ export async function runHttpQuery(
     // passed in.
     cache: options.cache!,
     dataSources: options.dataSources,
+    disableValidation: options.disableValidation,
     documentStore: options.documentStore,
 
     persistedQueries: options.persistedQueries,

diff --git a/packages/apollo-server-core/src/types.ts b/packages/apollo-server-core/src/types.ts
@@ -107,6 +107,7 @@ export interface Config<ContextFunctionParams = any> extends BaseConfig {
   stopOnTerminationSignals?: boolean;
   apollo?: ApolloConfigInput;
   nodeEnv?: string;
+  disableValidation?: boolean;
   documentStore?: DocumentStore | null;
   csrfPrevention?: CSRFPreventionOptions | boolean;
   cache?: KeyValueCache | 'bounded';

diff --git a/packages/apollo-server-integration-testsuite/src/ApolloServer.ts b/packages/apollo-server-integration-testsuite/src/ApolloServer.ts
@@ -282,6 +282,22 @@ export function testApolloServer<AS extends ApolloServerBase>(
           );
         });
 
+        it('Allows disabling query validation', async () => {
+          const { url: uri } = await createApolloServer({
+            schema,
+            stopOnTerminationSignals: false,
+            nodeEnv: 'production',
+            cache: 'bounded',
+            disableValidation: true,
+          });
+
+          const apolloFetch = createApolloFetch({ uri });
+
+          const result = await apolloFetch({ query: INTROSPECTION_QUERY });
+          expect(result.errors).toBeUndefined();
+          expect(result.data).toBeDefined();
+        });
+
         it('allows introspection to be enabled explicitly', async () => {
           const { url: uri } = await createApolloServer({
             schema,