major bump

apocas · Oct 11, 2023 · 1848635 · 1848635
1 parent 428f22a
commit 1848635
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 26 deletions.
diff --git a/lib/docker.js b/lib/docker.js
@@ -51,6 +51,7 @@ Docker.prototype.createContainer = function(opts, callback) {
     statusCodes: {
       200: true, // unofficial, but proxies may return it
       201: true,
+      400: 'bad parameter',
       404: 'no such container',
       406: 'impossible to attach',
       500: 'server error'

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "dockerode",
   "description": "Docker Remote API module.",
-  "version": "3.3.5",
+  "version": "4.0.0",
   "author": "Pedro Dias <petermdias@gmail.com>",
   "maintainers": [
     "apocas <petermdias@gmail.com>"
@@ -16,7 +16,7 @@
   ],
   "dependencies": {
     "@balena/dockerignore": "^1.0.2",
-    "docker-modem": "^3.0.0",
+    "docker-modem": "^5.0.0",
     "tar-fs": "~2.0.1"
   },
   "devDependencies": {

diff --git a/test/container.js b/test/container.js
@@ -71,9 +71,8 @@ describe("#container", function() {
     it("should put an archive inside the container", function(done) {
       var container = docker.getContainer(testContainer);
 
-      function handler(err, data) {
+      function handler(err) {
         expect(err).to.be.null;
-        expect(data).to.be.ok;
         done();
       }
 

diff --git a/test/docker.js b/test/docker.js
@@ -433,7 +433,6 @@ describe("#docker", function() {
         expect(container).to.be.ok;
 
         container.remove(function(err, data) {
-          console.log(data)
           expect(err).to.be.null;
           done();
         });

diff --git a/test/plugin.js b/test/plugin.js
@@ -115,9 +115,8 @@ describe("#plugin", function() {
       this.timeout(15000);
       var plugin = docker.getPlugin('sshfs');
 
-      function handler(err, data) {
+      function handler(err) {
         expect(err).to.be.null;
-        expect(data).to.be.ok;
         done();
       }
 

diff --git a/test/swarm.js b/test/swarm.js
@@ -99,9 +99,8 @@ describe("#swarm", function() {
     it("should update secret", function(done) {
       this.timeout(15000);
 
-      function handler(err, data) {
+      function handler(err) {
         expect(err).to.be.null;
-        expect(data).to.be.ok;
         done();
       }
       var opts = {
@@ -180,9 +179,8 @@ describe("#swarm", function() {
     it("should update config", function(done) {
       this.timeout(15000);
 
-      function handler(err, data) {
+      function handler(err) {
         expect(err).to.be.null;
-        expect(data).to.be.ok;
         done();
       }
       var opts = {