Merge pull request #15731 from apache/fix-line-animation

[Fix] [line] fix animation is not stopped when direct update points.
apache · Sep 15, 2021 · 6384acf · 6384acf
2 parents 26e9a95 + 4824ada
commit 6384acf
Show file tree

Hide file tree

Showing 6 changed files with 112 additions and 9 deletions.
diff --git a/src/chart/line/LineView.ts b/src/chart/line/LineView.ts
@@ -1290,17 +1290,18 @@ class LineView extends ChartView {
             next = turnPointsIntoStep(diff.next, coordSys, step);
             stackedOnNext = turnPointsIntoStep(diff.stackedOnNext, coordSys, step);
         }
-
         // Don't apply animation if diff is large.
         // For better result and avoid memory explosion problems like
         // https://github.com/apache/incubator-echarts/issues/12229
         if (getBoundingDiff(current, next) > 3000
             || (polygon && getBoundingDiff(stackedOnCurrent, stackedOnNext) > 3000)
         ) {
+            polyline.stopAnimation();
             polyline.setShape({
                 points: next
             });
             if (polygon) {
+                polygon.stopAnimation();
                 polygon.setShape({
                     points: next,
                     stackedOnPoints: stackedOnNext
@@ -1345,7 +1346,6 @@ class LineView extends ChartView {
             }
         }
 
-
         const updatedDataInfo: {
             el: SymbolExtended,
             ptIdx: number
@@ -1364,7 +1364,6 @@ class LineView extends ChartView {
                 }
             }
         }
-
         if (polyline.animators && polyline.animators.length) {
             polyline.animators[0].during(function () {
                 polygon && polygon.dirtyShape();

diff --git a/src/i18n/langPT-br.ts b/src/i18n/langPT-br.ts
@@ -24,7 +24,8 @@
 export default {
     time: {
         month: [
-            'Janeiro', 'Fevereiro', 'Março', 'Abril', 'Maio', 'Junho', 'Julho', 'Agosto', 'Setembro', 'Outubro', 'Novembro', 'Dezembro'
+            'Janeiro', 'Fevereiro', 'Março', 'Abril', 'Maio', 'Junho',
+            'Julho', 'Agosto', 'Setembro', 'Outubro', 'Novembro', 'Dezembro'
         ],
         monthAbbr: [
             'Jan', 'Fev', 'Mar', 'Abr', 'Mai', 'Jun',

diff --git a/test/line-extraneous.html → test/line-animation-update.html b/test/line-extraneous.html → test/line-animation-update.html
diff --git a/test/line-case.html b/test/line-case.html
diff --git a/test/runTest/actions/__meta__.json b/test/runTest/actions/__meta__.json
diff --git a/test/runTest/actions/line-extraneous.json → ...unTest/actions/line-animation-update.json b/test/runTest/actions/line-extraneous.json → ...unTest/actions/line-animation-update.json