Skip to content

Commit

Permalink
chore(tests): circleci - chrome 69 requires chromdriver to 2.44 (#5182)
Browse files Browse the repository at this point in the history
- Move circle.yml file to .circleci/config.yml to satisfy circleci
warnings (version 1.0 deprecation).
- The browser in circle is version 69. The browser requires chromedriver
2.44.
  • Loading branch information
cnishina committed Mar 23, 2019
1 parent 3d50b68 commit d777738
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions circle.yml → .circleci/config.yml
Expand Up @@ -54,8 +54,8 @@ jobs:
name: Selenium Start
background: true
command: |
./node_modules/.bin/webdriver-manager update
./node_modules/.bin/webdriver-manager start
./node_modules/.bin/webdriver-manager update --versions.chrome=2.44
./node_modules/.bin/webdriver-manager start --versions.chrome=2.44
- run:
name: TestApp Start
Expand Down
6 changes: 4 additions & 2 deletions gulpfile.js
Expand Up @@ -40,7 +40,8 @@ gulp.task('tslint', () => {

gulp.task('format:enforce', () => {
return gulp.src(['lib/**/*.ts'])
.pipe(format.checkFormat('file', clangFormat, {verbose: true, fail: true}));
.pipe(format.checkFormat('file', clangFormat,
{verbose: true, fail: true}));
});

gulp.task('lint', gulp.series('tslint', 'format:enforce'));
Expand Down Expand Up @@ -71,7 +72,8 @@ gulp.task('built:copy:typings', () => {
});

gulp.task('webdriver:update', (done) => {
runSpawn(done, 'node', ['bin/webdriver-manager', 'update']);
runSpawn(done, 'node', ['bin/webdriver-manager', 'update',
'--versions.chrome=2.44']);
});

gulp.task('format', () => {
Expand Down

0 comments on commit d777738

Please sign in to comment.