Skip to content

Commit

Permalink
chore(test): remove jasmine addMatcher test (#5072)
Browse files Browse the repository at this point in the history
- Removing the addMatchers test since we no longer support async calls
resolve with jasminewd since we removed jasminewd. Also Jasmine does
not appear to support async calls in custom expectations or the
compare method.
  • Loading branch information
cnishina committed Mar 23, 2019
1 parent 6522e40 commit 9d510db
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions spec/basic/locators_spec.js
Expand Up @@ -10,23 +10,6 @@ describe('locators', () => {
expect(await greeting.getText()).toEqual('Hiya');
});

// TODO(selenium4): fix/remove xit after removing jasminewd
xit('should allow custom expectations to expect an element', async() => {
jasmine.addMatchers({
toHaveText: () => {
return {
compare: async(actual, expected) => {
return {
pass: (await actual.getText()) === expected
};
}
};
}
});

expect(await element(by.binding('greeting'))).toHaveText('Hiya');
});

it('should find a binding by partial match', async() => {
const greeting = element(by.binding('greet'));

Expand Down

0 comments on commit 9d510db

Please sign in to comment.