fix(forms): Convert existing reactive errors to use RuntimeErrorCode. #46560

dylhunn · 2022-06-28T19:52:06Z

This allows for better tree-shakability, as well as the addition of guides in the future as needed.

packages/forms/src/directives/reactive_errors.ts

This allows for better tree-shakability, as well as the addition of guides in the future as needed.

AndrewKushnir

👍

AndrewKushnir

Reviewed-for: public-api

jessicajaniuk

reviewed-for: public-api

ngbot · 2022-06-29T15:47:41Z

I see that you just added the action: merge label, but the following checks are still failing:
status "google3" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

atscott · 2022-06-29T16:02:06Z

presubmit

dylhunn · 2022-06-29T16:33:05Z

@atscott The broken targets in the presubmit actually seem to be broken in the current sync, as of late yesterday. I suspect #46568 as the cause (or possibly #46530). I will find out and roll back the culprit shortly.

dylhunn · 2022-06-29T17:15:45Z

This PR was merged into the repository by commit 0a5c8c0.

…#46560) This allows for better tree-shakability, as well as the addition of guides in the future as needed. PR Close #46560

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.3/14.0.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.3/14.0.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.3/14.0.4) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.3/14.0.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.3/14.0.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.3/14.0.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.3/14.0.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.3/14.0.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1404-2022-06-29) [Compare Source](angular/angular@14.0.3...14.0.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [51be9bbe29](angular/angular@51be9bb) | fix | cleanup DOM elements when the root view is removed ([#45143](angular/angular#45143)) | | [999aca86c8](angular/angular@999aca8) | fix | enable shadowElements to leave when their parent does ([#46459](angular/angular#46459)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [42aed6b13e](angular/angular@42aed6b) | fix | handle CSS custom properties in NgStyle ([#46451](angular/angular#46451)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [1e7f22f00a](angular/angular@1e7f22f) | fix | trigger `ApplicationRef.destroy` when Platform is destroyed ([#46497](angular/angular#46497)) | | [8bde2dbc71](angular/angular@8bde2db) | fix | Update ngfor error code to be negative ([#46555](angular/angular#46555)) | | [57e8fc00eb](angular/angular@57e8fc0) | fix | Updates error to use RuntimeError code ([#46526](angular/angular#46526)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [74a26d870e](angular/angular@74a26d8) | fix | Convert existing reactive errors to use RuntimeErrorCode. ([#46560](angular/angular#46560)) | | [747872212d](angular/angular@7478722) | fix | Update a Forms validator error to use RuntimeError ([#46537](angular/angular#46537)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [d6fac9e914](angular/angular@d6fac9e) | fix | Ensure that new `RouterOutlet` instances work after old ones are destroyed ([#46554](angular/angular#46554)) | #### Special Thanks Alan Agius, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Bezael, Chad Ramos, Chellappan, Cédric Exbrayat, Dylan Hunn, George Kalpakas, Jeremy Meiss, Jessica Janiuk, Joey Perrott, KMathy, Kristiyan Kostadinov, Paul Gschwendtner, Pawel Kozlowski, Ramesh Thiruchelvam, Vaibhav Kumar, arturovt, dario-piotrowicz and renovate\[bot]  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1437 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-07-30T16:07:00Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: patch This PR is targeted for the next patch release labels Jun 28, 2022

dylhunn requested a review from AndrewKushnir June 28, 2022 19:52

ngbot bot modified the milestone: Backlog Jun 28, 2022

pullapprove bot requested review from alxhub and atscott June 28, 2022 19:52

dylhunn modified the milestones: Backlog, Fixit H1'2022 Jun 28, 2022

atscott reviewed Jun 28, 2022

View reviewed changes

packages/forms/src/directives/reactive_errors.ts Show resolved Hide resolved

pullapprove bot requested a review from atscott June 28, 2022 20:10

fix(forms): Convert existing reactive errors to use RuntimeErrorCode.

1ccdfb0

This allows for better tree-shakability, as well as the addition of guides in the future as needed.

dylhunn force-pushed the f-ec branch from 6d04bbd to 1ccdfb0 Compare June 28, 2022 20:36

AndrewKushnir approved these changes Jun 29, 2022

View reviewed changes

pullapprove bot requested a review from AndrewKushnir June 29, 2022 00:34

AndrewKushnir approved these changes Jun 29, 2022

View reviewed changes

pullapprove bot requested a review from jessicajaniuk June 29, 2022 00:35

jessicajaniuk approved these changes Jun 29, 2022

View reviewed changes

jessicajaniuk removed request for atscott and alxhub June 29, 2022 15:47

jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 29, 2022

dylhunn added a commit that referenced this pull request Jun 29, 2022

fix(forms): Convert existing reactive errors to use RuntimeErrorCode. (…

74a26d8

…#46560) This allows for better tree-shakability, as well as the addition of guides in the future as needed. PR Close #46560

dylhunn closed this in 0a5c8c0 Jun 29, 2022

This was referenced Jul 1, 2022

build(deps-dev): bump @angular/language-service from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1761

Closed

build(deps-dev): bump @angular/compiler from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1755

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2022

dylhunn deleted the f-ec branch October 17, 2022 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(forms): Convert existing reactive errors to use RuntimeErrorCode. #46560

fix(forms): Convert existing reactive errors to use RuntimeErrorCode. #46560

dylhunn commented Jun 28, 2022

AndrewKushnir left a comment

AndrewKushnir left a comment

jessicajaniuk left a comment

ngbot bot commented Jun 29, 2022

atscott commented Jun 29, 2022

dylhunn commented Jun 29, 2022

dylhunn commented Jun 29, 2022

angular-automatic-lock-bot bot commented Jul 30, 2022

fix(forms): Convert existing reactive errors to use RuntimeErrorCode. #46560

fix(forms): Convert existing reactive errors to use RuntimeErrorCode. #46560

Conversation

dylhunn commented Jun 28, 2022

AndrewKushnir left a comment

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

jessicajaniuk left a comment

Choose a reason for hiding this comment

ngbot bot commented Jun 29, 2022

atscott commented Jun 29, 2022

dylhunn commented Jun 29, 2022

dylhunn commented Jun 29, 2022

angular-automatic-lock-bot bot commented Jul 30, 2022