fix(core): Update ngfor error code to be negative #46555

jessicajaniuk · 2022-06-28T18:04:17Z

This adds the fancy link to the error code documentation automatically

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Error code is non-negative, meaning it won't auto insert the docs link

Issue Number: N/A

What is the new behavior?

The error code is now negative, and the docs link inserts itself.

Does this PR introduce a breaking change?

Yes
No

Other information

This adds the fancy link to the error code documentation automatically

dylhunn

reviewed-for: public-api

jessicajaniuk · 2022-06-28T18:34:36Z

Caretaker: This can skip public API approval since it doesn't functionally change anything.

AndrewKushnir

Reviewed-for: public-api

dylhunn · 2022-06-28T19:59:09Z

This PR was merged into the repository by commit 606d942.

This adds the fancy link to the error code documentation automatically PR Close #46555

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.3/14.0.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.3/14.0.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.3/14.0.4) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.3/14.0.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.3/14.0.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.3/14.0.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.3/14.0.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.3/14.0.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1404-2022-06-29) [Compare Source](angular/angular@14.0.3...14.0.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [51be9bbe29](angular/angular@51be9bb) | fix | cleanup DOM elements when the root view is removed ([#45143](angular/angular#45143)) | | [999aca86c8](angular/angular@999aca8) | fix | enable shadowElements to leave when their parent does ([#46459](angular/angular#46459)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [42aed6b13e](angular/angular@42aed6b) | fix | handle CSS custom properties in NgStyle ([#46451](angular/angular#46451)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [1e7f22f00a](angular/angular@1e7f22f) | fix | trigger `ApplicationRef.destroy` when Platform is destroyed ([#46497](angular/angular#46497)) | | [8bde2dbc71](angular/angular@8bde2db) | fix | Update ngfor error code to be negative ([#46555](angular/angular#46555)) | | [57e8fc00eb](angular/angular@57e8fc0) | fix | Updates error to use RuntimeError code ([#46526](angular/angular#46526)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [74a26d870e](angular/angular@74a26d8) | fix | Convert existing reactive errors to use RuntimeErrorCode. ([#46560](angular/angular#46560)) | | [747872212d](angular/angular@7478722) | fix | Update a Forms validator error to use RuntimeError ([#46537](angular/angular#46537)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [d6fac9e914](angular/angular@d6fac9e) | fix | Ensure that new `RouterOutlet` instances work after old ones are destroyed ([#46554](angular/angular#46554)) | #### Special Thanks Alan Agius, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Bezael, Chad Ramos, Chellappan, Cédric Exbrayat, Dylan Hunn, George Kalpakas, Jeremy Meiss, Jessica Janiuk, Joey Perrott, KMathy, Kristiyan Kostadinov, Paul Gschwendtner, Pawel Kozlowski, Ramesh Thiruchelvam, Vaibhav Kumar, arturovt, dario-piotrowicz and renovate\[bot]  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1437 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-07-29T16:07:02Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jessicajaniuk added the area: core Issues related to the framework runtime label Jun 28, 2022

ngbot bot added this to the Backlog milestone Jun 28, 2022

jessicajaniuk requested a review from dylhunn June 28, 2022 18:04

jessicajaniuk added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 28, 2022

dylhunn approved these changes Jun 28, 2022

View reviewed changes

fix(core): Update ngfor error code to be negative

2be96f0

This adds the fancy link to the error code documentation automatically

jessicajaniuk force-pushed the ngforof-fix branch from a7f2349 to 2be96f0 Compare June 28, 2022 18:33

pullapprove bot requested review from AndrewKushnir, atscott and pkozlowski-opensource June 28, 2022 18:33

jessicajaniuk added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 28, 2022

dylhunn self-requested a review June 28, 2022 18:34

dylhunn approved these changes Jun 28, 2022

View reviewed changes

AndrewKushnir approved these changes Jun 28, 2022

View reviewed changes

AndrewKushnir removed request for atscott and pkozlowski-opensource June 28, 2022 18:35

jessicajaniuk removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 28, 2022

dylhunn pushed a commit that referenced this pull request Jun 28, 2022

fix(core): Update ngfor error code to be negative (#46555)

8bde2db

This adds the fancy link to the error code documentation automatically PR Close #46555

dylhunn closed this in 606d942 Jun 28, 2022

This was referenced Jul 1, 2022

build(deps-dev): bump @angular/language-service from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1761

Closed

build(deps-dev): bump @angular/compiler from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1755

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2022

jessicajaniuk deleted the ngforof-fix branch January 27, 2023 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Update ngfor error code to be negative #46555

fix(core): Update ngfor error code to be negative #46555

jessicajaniuk commented Jun 28, 2022

dylhunn left a comment

jessicajaniuk commented Jun 28, 2022

AndrewKushnir left a comment

dylhunn commented Jun 28, 2022

angular-automatic-lock-bot bot commented Jul 29, 2022

fix(core): Update ngfor error code to be negative #46555

fix(core): Update ngfor error code to be negative #46555

Conversation

jessicajaniuk commented Jun 28, 2022

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

dylhunn left a comment

Choose a reason for hiding this comment

jessicajaniuk commented Jun 28, 2022

AndrewKushnir left a comment

Choose a reason for hiding this comment

dylhunn commented Jun 28, 2022

angular-automatic-lock-bot bot commented Jul 29, 2022