fix(core): deduplicate imports of standalone components in JIT compiler #46439

JoostK · 2022-06-20T19:20:42Z

During JIT compilation of standalone components the compiler did not deduplicate
declarations in the imports array, unlike the AOT compiler. This may result in
runtime errors during directive matching, when the same component is found
multiple times resulting in NG0300, for example:

NG0300: Multiple components match node with tagname mat-form-field: MatFormField and MatFormField.

This commit fixes the issue by deduplicating imports in the JIT compiler.

Relates to #46109 (comment)

Closes #46109

pkozlowski-opensource · 2022-06-21T12:08:07Z

packages/core/src/render3/jit/directive.ts

@@ -246,16 +246,23 @@ function getStandaloneDefFunctions(type: Type<any>, imports: Type<any>[]): {
      // Standalone components are always able to self-reference, so include the component's own
      // definition in its `directiveDefs`.
      cachedDirectiveDefs = [getComponentDef(type)!];
+      const seen = new Set<Type<any>>();


nit: any => unknown?

pkozlowski-opensource · 2022-06-21T12:11:03Z

packages/core/test/acceptance/standalone_spec.ts

@@ -453,6 +453,42 @@ describe('standalone components, directives and pipes', () => {
    expect(fixture.nativeElement.innerHTML).toBe('<div red="true">blue</div>');
  });

+  it('should deduplicate declarations', () => {


Was thinking of a test scenario to verify de-duped pipes but nothing comes to my mind (short of explicitly asserting on a def...)

Yeah I was pondering the same; decided to keep as is as inspecting the pipe defs seems overkill and there won't be a behavior difference (but it felt incorrect not to deduplicate pipes)

pkozlowski-opensource

LGTM

During JIT compilation of standalone components the compiler did not deduplicate declarations in the imports array, unlike the AOT compiler. This may result in runtime errors during directive matching, when the same component is found multiple times resulting in NG0300, for example: > NG0300: Multiple components match node with tagname mat-form-field: MatFormField and MatFormField. This commit fixes the issue by deduplicating imports in the JIT compiler. Relates to angular#46109 (comment) Closes angular#46109

pkozlowski-opensource

LGTM

AndrewKushnir · 2022-06-21T18:56:55Z

Presubmit.

AndrewKushnir · 2022-06-21T19:41:18Z

This PR was merged into the repository by commit ddd6d66.

…er (#46439) During JIT compilation of standalone components the compiler did not deduplicate declarations in the imports array, unlike the AOT compiler. This may result in runtime errors during directive matching, when the same component is found multiple times resulting in NG0300, for example: > NG0300: Multiple components match node with tagname mat-form-field: MatFormField and MatFormField. This commit fixes the issue by deduplicating imports in the JIT compiler. Relates to #46109 (comment) Closes #46109 PR Close #46439

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.2/14.0.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.2/14.0.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.2/14.0.3) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.2/14.0.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.2/14.0.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.2/14.0.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.2/14.0.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.2/14.0.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1403-2022-06-22) [Compare Source](angular/angular@14.0.2...14.0.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [3dd7bb3f8f](angular/angular@3dd7bb3) | fix | reset the start and done fns on player reset ([#46364](angular/angular#46364)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [c086653655](angular/angular@c086653) | fix | deduplicate imports of standalone components in JIT compiler ([#46439](angular/angular#46439)) | | [5d3b97e1f8](angular/angular@5d3b97e) | fix | handle NgModules with standalone pipes in TestBed correctly ([#46407](angular/angular#46407)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [6ad7b40a6f](angular/angular@6ad7b40) | fix | invalid style attribute being generated for null values ([#46433](angular/angular#46433)) | #### Special Thanks 4javier, Aakash, Alan Agius, Andrew Kushnir, Aristeidis Bampakos, Dany Paredes, Derek Cormier, JoostK, Kristiyan Kostadinov, Paul Gschwendtner, Ramesh Thiruchelvam, behrooz bozorg chami, dario-piotrowicz, markostanimirovic, renovate\[bot] and web-dave  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1431 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-07-22T16:06:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

JoostK added area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler compiler: jit cross-cutting: standalone Issues related to the NgModule-less world labels Jun 20, 2022

ngbot bot modified the milestone: Backlog Jun 20, 2022

JoostK mentioned this pull request Jun 20, 2022

unintended duplicate imports can cause rendering error in standalone component life cycle. #46109

Closed

JoostK force-pushed the standalone-jit-dedup branch from 0420176 to 58d872f Compare June 20, 2022 19:30

JoostK marked this pull request as ready for review June 20, 2022 20:02

JoostK added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 20, 2022

pullapprove bot requested a review from atscott June 20, 2022 20:02

JoostK requested review from pkozlowski-opensource and removed request for atscott June 20, 2022 20:02

JoostK force-pushed the standalone-jit-dedup branch from 58d872f to a3dd447 Compare June 21, 2022 06:24

pkozlowski-opensource reviewed Jun 21, 2022

View reviewed changes

pkozlowski-opensource approved these changes Jun 21, 2022

View reviewed changes

pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 21, 2022

JoostK force-pushed the standalone-jit-dedup branch from a3dd447 to b6faa2e Compare June 21, 2022 16:33

angular-robot bot requested a review from pkozlowski-opensource June 21, 2022 16:33

pkozlowski-opensource approved these changes Jun 21, 2022

View reviewed changes

JoostK added the action: presubmit The PR is in need of a google3 presubmit label Jun 21, 2022

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Jun 21, 2022

AndrewKushnir closed this in ddd6d66 Jun 21, 2022

This was referenced Jul 1, 2022

build(deps-dev): bump @angular/language-service from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1761

Closed

build(deps-dev): bump @angular/compiler from 12.2.4 to 14.0.4 numbersprotocol/capture-lite#1755

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): deduplicate imports of standalone components in JIT compiler #46439

fix(core): deduplicate imports of standalone components in JIT compiler #46439

JoostK commented Jun 20, 2022

pkozlowski-opensource Jun 21, 2022

pkozlowski-opensource Jun 21, 2022

JoostK Jun 21, 2022

pkozlowski-opensource left a comment

pkozlowski-opensource left a comment

AndrewKushnir commented Jun 21, 2022

AndrewKushnir commented Jun 21, 2022

angular-automatic-lock-bot bot commented Jul 22, 2022

fix(core): deduplicate imports of standalone components in JIT compiler #46439

fix(core): deduplicate imports of standalone components in JIT compiler #46439

Conversation

JoostK commented Jun 20, 2022

pkozlowski-opensource Jun 21, 2022

Choose a reason for hiding this comment

pkozlowski-opensource Jun 21, 2022

Choose a reason for hiding this comment

JoostK Jun 21, 2022

Choose a reason for hiding this comment

pkozlowski-opensource left a comment

Choose a reason for hiding this comment

pkozlowski-opensource left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Jun 21, 2022

AndrewKushnir commented Jun 21, 2022

angular-automatic-lock-bot bot commented Jul 22, 2022