New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): handle NgModules with standalone pipes in TestBed correctly #46407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents Prior to standalone components, the `applyProviderOverridesToModule` method was used exclusively for NgModules. With standalone, its scope was expended to include standalone components as well. This commit renames the method to `applyProviderOverridesInScope` to better reflect this + also renames a field that refers to a set that contains already overridden types.
Prior to this commit, the TestBed logic erroneously tried to apply provider overrides to standalone pipes that were imported in an NgModule. This commit updates the logic to recognize types that may have a scope (an NgModule or a standalone component) and skip other types while applying provider overrides recursively.
AndrewKushnir
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
area: core
Issues related to the framework runtime
target: patch
This PR is targeted for the next patch release
cross-cutting: standalone
Issues related to the NgModule-less world
labels
Jun 17, 2022
3 tasks
alxhub
approved these changes
Jun 17, 2022
AndrewKushnir
added
action: presubmit
The PR is in need of a google3 presubmit
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
action: presubmit
The PR is in need of a google3 presubmit
labels
Jun 17, 2022
This PR was merged into the repository by commit 3d8787c. |
AndrewKushnir
added a commit
that referenced
this pull request
Jun 21, 2022
…onents (#46407) Prior to standalone components, the `applyProviderOverridesToModule` method was used exclusively for NgModules. With standalone, its scope was expended to include standalone components as well. This commit renames the method to `applyProviderOverridesInScope` to better reflect this + also renames a field that refers to a set that contains already overridden types. PR Close #46407
AndrewKushnir
added a commit
that referenced
this pull request
Jun 21, 2022
#46407) Prior to this commit, the TestBed logic erroneously tried to apply provider overrides to standalone pipes that were imported in an NgModule. This commit updates the logic to recognize types that may have a scope (an NgModule or a standalone component) and skip other types while applying provider overrides recursively. PR Close #46407
AndrewKushnir
added a commit
that referenced
this pull request
Jun 21, 2022
#46407) Prior to this commit, the TestBed logic erroneously tried to apply provider overrides to standalone pipes that were imported in an NgModule. This commit updates the logic to recognize types that may have a scope (an NgModule or a standalone component) and skip other types while applying provider overrides recursively. PR Close #46407
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 28, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.2/14.0.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.2/14.0.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.2/14.0.3) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.2/14.0.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.2/14.0.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.2/14.0.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.2/14.0.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.2/14.0.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1403-2022-06-22) [Compare Source](angular/angular@14.0.2...14.0.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [3dd7bb3f8f](angular/angular@3dd7bb3) | fix | reset the start and done fns on player reset ([#​46364](angular/angular#46364)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [c086653655](angular/angular@c086653) | fix | deduplicate imports of standalone components in JIT compiler ([#​46439](angular/angular#46439)) | | [5d3b97e1f8](angular/angular@5d3b97e) | fix | handle NgModules with standalone pipes in TestBed correctly ([#​46407](angular/angular#46407)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [6ad7b40a6f](angular/angular@6ad7b40) | fix | invalid style attribute being generated for null values ([#​46433](angular/angular#46433)) | #### Special Thanks 4javier, Aakash, Alan Agius, Andrew Kushnir, Aristeidis Bampakos, Dany Paredes, Derek Cormier, JoostK, Kristiyan Kostadinov, Paul Gschwendtner, Ramesh Thiruchelvam, behrooz bozorg chami, dario-piotrowicz, markostanimirovic, renovate\[bot] and web-dave <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1431 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: core
Issues related to the framework runtime
cross-cutting: standalone
Issues related to the NgModule-less world
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the TestBed logic erroneously tried to apply provider overrides to standalone pipes that were imported in an NgModule. This commit updates the logic to recognize types that may have a scope (an NgModule or a standalone component) and skip other types while applying provider overrides recursively.
Note to the reviewers: this PR has 2 commits (one is a refactoring and the second is an actual fix), it might be easier to review commits individually.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?