Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): allow null in ngComponentOutlet #46280

Closed
wants to merge 1 commit into from
Closed

fix(common): allow null in ngComponentOutlet #46280

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2022

ngComponentOutlet already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes #45716.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jun 7, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 7, 2022
@pullapprove pullapprove bot requested review from atscott June 7, 2022 07:32
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@crisbeto
fix(common): allow null in ngComponentOutlet
0c5cf63 
`ngComponentOutlet` already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes angular#45716.
AndrewKushnir
AndrewKushnir approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @crisbeto 👍

AndrewKushnir
AndrewKushnir approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 7, 2022
atscott
atscott approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Jun 9, 2022
@jessicajaniuk jessicajaniuk removed the request for review from atscott June 9, 2022 16:01
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 8b9c32d.

jessicajaniuk pushed a commit that referenced this pull request Jun 9, 2022
@crisbeto @jessicajaniuk
fix(common): allow null in ngComponentOutlet (#46280)
ef5cba3 
`ngComponentOutlet` already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes #45716.

PR Close #46280
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 17, 2022
Update angular monorepo (#1420)
48def1c 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.1/14.0.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.1/14.0.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.1/14.0.2) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.1/14.0.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.1/14.0.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.1/14.0.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.1/14.0.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.1` -> `14.0.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.1/14.0.2) |
| [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.5` -> `0.11.6`](https://renovatebot.com/diffs/npm/zone.js/0.11.5/0.11.6) |

---

### Release Notes

<details>
<summary>angular/angular (@&#8203;angular/animations)</summary>

### [`v14.0.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1402-2022-06-15)

[Compare Source](angular/angular@14.0.1...14.0.2)

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [ef5cba3df7](angular/angular@ef5cba3) | fix | allow null in ngComponentOutlet ([#&#8203;46280](angular/angular#46280)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [8ecfd71fd7](angular/angular@8ecfd71) | fix | don't emit empty providers array ([#&#8203;46301](angular/angular#46301)) |
| [b92c1a6ada](angular/angular@b92c1a6) | fix | use inline type-check blocks for components outside `rootDir` ([#&#8203;46096](angular/angular#46096)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [3fd8948b4a](angular/angular@3fd8948) | fix | Resolve forwardRef declarations for jit ([#&#8203;46334](angular/angular#46334)) |

#### Special Thanks

Alex Rickabaugh, Andrew Scott, Badawi7, Daniel Schmitz, Derek Cormier, JoostK, Kevin Davila, Kristiyan Kostadinov, Paul Draper, Paul Gschwendtner, Tom Eustace, Totati, Younes Jaaidi, alefra, dario-piotrowicz, markostanimirovic, mgechev, piyush132000, sten-bone and vivekkoya

<!-- CHANGELOG SPLIT MARKER -->

</details>

<details>
<summary>angular/angular (zone.js)</summary>

### [`v0.11.6`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#&#8203;0116-httpsgithubcomangularangularcomparezonejs-0115zonejs-0116-2022-06-02)

[Compare Source](angular/angular@zone.js-0.11.5...zone.js-0.11.6)

##### Bug Fixes

-   **zone.js:** check if `process` is defined when patching the `GlobalErrors.install` ([#&#8203;45392](angular/angular#45392)) ([c7bcc1b](angular/angular@c7bcc1b)), closes [#&#8203;42260](angular/angular#42260)
-   **zone.js:** in TaskTrackingZoneSpec track a periodic task until it is cancelled ([#&#8203;45391](angular/angular#45391)) ([f19b36f](angular/angular@f19b36f))
-   **zone.js:** read `Symbol.species` safely ([#&#8203;45369](angular/angular#45369)) ([e2eaac3](angular/angular@e2eaac3))
-   **zone.js:** should ignore multiple resolve call ([#&#8203;45283](angular/angular#45283)) ([aebf165](angular/angular@aebf165)), closes [#&#8203;44913](angular/angular#44913)
-   **zone.js:** swallow the error when the element callback is not patchable ([#&#8203;45400](angular/angular#45400)) ([4ea70e3](angular/angular@4ea70e3)), closes [lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186](https://github.com/lwc/engine-core/src/framework/base-bridge-element.ts/issues/L180-L186) [#&#8203;42546](angular/angular#42546)

##### BREAKING CHANGES

-   **zone.js:** in TaskTrackingZoneSpec track a periodic task until it is cancelled

The breaking change is scoped only to the plugin
`zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and
checked the pending macroTasks e.g. using `(this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then
its behavior slightly changed for periodic macrotasks. For example,
previously the `setInterval` macrotask was no longer tracked after its
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with `clearInterval(id)`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1420
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

*ngComponentOutlet types don't allow null/undefined, even though it supports it
6 participants
@crisbeto @jessicajaniuk @atscott @pkozlowski-opensource @alxhub @AndrewKushnir