Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: cut the zone.js-0.11.6 release #46232

Closed
wants to merge 1 commit into from
Closed

release: cut the zone.js-0.11.6 release #46232

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

Close #46230

@JiaLiPassion JiaLiPassion requested a review from alxhub June 2, 2022 22:22
@ngbot ngbot bot added this to the Backlog milestone Jun 2, 2022
Platonn
Platonn reviewed Jun 3, 2022
View reviewed changes
packages/zone.js/CHANGELOG.md Outdated
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with `clearInterval(id)`.

fixes 45350
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fixes 45350
fixes [#45350](https://github.com/angular/angular/pull/45350)

I also fixed the link in the main Angular changelog in the PR #46238

Copy link
Contributor

@Platonn Platonn Jun 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for confusion. I can see now I was advised by @gkalpak to remove the whole "fixes" notice from "breaking changes" section. See comment #46238 (comment)

Suggested change
fixes 45350

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Platonn , got it, I removed the fixes part.

@Platonn Platonn mentioned this pull request Jun 8, 2022
Closed
@JiaLiPassion JiaLiPassion added the target: minor This PR is targeted for the next minor release label Jun 11, 2022
@angular-robot angular-robot bot requested a review from alxhub June 11, 2022 01:06
@dylhunn
Copy link
Contributor

dylhunn commented Jun 13, 2022 •
edited

@JiaLiPassion Do you have plans to release zone.js soon? (I have reopened #46230 as well.)

@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Jun 14, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 1120d54.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Platonn Platonn Platonn left review comments

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Missing release of zone.js along with Angular 14.0.0
5 participants
@JiaLiPassion @dylhunn @jessicajaniuk @Platonn @alxhub