Skip to content

Commit

Permalink
build: avoid use of ts-node wrapper script as it breaks child proce…
Browse files Browse the repository at this point in the history
…ss forking (#46456)

`ts-node` spawns a custom node launcher script and has a brotli-base64
encoded configuration that will point to the user-provided entry-point.

This breaks child process forking as we wouldn't be able to specify our
custom build worker and basically `ng-dev` would run inside `ng-dev`
again.

PR Close #46456
  • Loading branch information
devversion authored and AndrewKushnir committed Jun 22, 2022
1 parent d6528b1 commit 8722edd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
7 changes: 4 additions & 3 deletions package.json
Expand Up @@ -24,7 +24,7 @@
"/ ": "",
"postinstall": "node scripts/webdriver-manager-update.js && node --preserve-symlinks --preserve-symlinks-main ./tools/postinstall-patches.js",
"prepare": "husky install",
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"ng-dev": "cross-env TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json node --no-warnings --loader ts-node/esm node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"build": "ts-node --esm --project scripts/tsconfig.json scripts/build/build-packages-dist.mts",
"test": "bazelisk test",
"test:ci": "bazelisk test -- //... -//devtools/... -//aio/...",
Expand Down Expand Up @@ -92,8 +92,8 @@
"@types/convert-source-map": "^1.5.1",
"@types/diff": "^5.0.0",
"@types/events": "3.0.0",
"@types/hammerjs": "2.0.41",
"@types/filesystem": "^0.0.32",
"@types/hammerjs": "2.0.41",
"@types/inquirer": "^8.0.0",
"@types/jasmine": "^4.0.0",
"@types/jasmine-ajax": "^3.3.1",
Expand Down Expand Up @@ -159,8 +159,8 @@
"rollup-plugin-sourcemaps": "^0.6.3",
"rxjs": "^6.6.7",
"selenium-webdriver": "3.5.0",
"shelljs": "^0.8.5",
"semver-dsl": "^1.0.1",
"shelljs": "^0.8.5",
"source-map": "^0.6.1",
"source-map-support": "0.5.21",
"sourcemap-codec": "^1.4.8",
Expand Down Expand Up @@ -196,6 +196,7 @@
"cldr": "7.2.0",
"cldrjs": "0.5.5",
"conventional-changelog": "^3.1.24",
"cross-env": "^7.0.3",
"firebase-tools": "^9.0.0",
"glob": "8.0.3",
"gulp": "^4.0.2",
Expand Down
7 changes: 7 additions & 0 deletions yarn.lock
Expand Up @@ -5374,6 +5374,13 @@ cross-env@^5.1.3:
dependencies:
cross-spawn "^6.0.5"

cross-env@^7.0.3:
version "7.0.3"
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
dependencies:
cross-spawn "^7.0.1"

cross-spawn@^6.0.5:
version "6.0.5"
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-6.0.5.tgz#4a5ec7c64dfae22c3a14124dbacdee846d80cbc4"
Expand Down

0 comments on commit 8722edd

Please sign in to comment.